Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When building xictools, the error messages come out with the incorrect directory references #24

Open
ElderDelp opened this issue Jun 12, 2024 · 3 comments

Comments

@ElderDelp
Copy link

ElderDelp commented Jun 12, 2024

Hi Stephen,

I have been building the tools from source. When I run it, unexpected crashes happen and I cannot tell what I did. As a help, I wanted to check the various compiler warnings. For the most part, from emacs, compile-mode has trouble finding the files. I think that it comes from a common structure used by many:

distclean:
	-@for a in $(SUBDIRS) packages; do \
	    if [ -d $$a ]; then \
	        (cd $$a; make $@) \
	    fi; \
	done
	-@rm -f config.cache config.log config.status configure Makefile
	-@rm -rf lib autom4te.cache
	-@rm -f include/config.h

The cd is not reported by make, so it leads to a problem for me as I try to find the sources.

I put in a pull request modifying (cd $$a; make $@) \ to ${MAKE} -C $$a $@; \.

distclean:
	-@for a in $(SUBDIRS) packages; do \
	    if [ -d $$a ]; then \
	        ${MAKE} -C $$a $@; \
	    fi; \
	done
	-@rm -f config.cache config.log config.status configure Makefile
	-@rm -rf lib autom4te.cache
	-@rm -f include/config.h

With that modification, emacs takes me to the correct source all the time.

#23

There were several place were the gcc -Wall complained about using an object after it is freed. They have all gone away.
That part is a mystery.

=====================

Parallelization of recursive jobs in GNU make sugests using the template:

SUBDIRS = a b c
default: all
$(SUBDIRS)::
    $(MAKE) -C $@ $(MAKECMDGOALS)
all clean : $(SUBDIRS)

or, if there are some dependancies use this template:

SUBDIRS = app lib doc

default: all

app: lib

.PHONY: $(SUBDIRS)

$(SUBDIRS):
    $(MAKE) -C $@ $(MAKECMDGOALS)

all clean install: $(SUBDIRS)
@ElderDelp
Copy link
Author

@wrcad just commited the first part of this issue, Thanks. If you would like another pull request that supports the parallel builds of subdirs, I would be happy to prepare one for that.

@wrcad
Copy link
Owner

wrcad commented Jun 13, 2024 via email

@ElderDelp
Copy link
Author

I am working on a pull request for enabling parallel builds .

For now I am deferring the wrspice module. Parts of that module are created from a .tgz file, e.g., the examples.
That is a impressive set of scripts...
I will work on that a bit later when I have clear mind to load up the full sequence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants