Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pleim-Xiu Package & Registry update for RA, RS, LANDUSEF, etc. #2025

Closed
wants to merge 2 commits into from

Conversation

coastwx
Copy link
Contributor

@coastwx coastwx commented Mar 21, 2024

Key variables for CMAQ AQ modeling from the WRF Pleim-Xiu LSM are not default in WRF outputs when LSM=7

TYPE: bug fix

KEYWORDS: Pleim-Xiu, RA, RS, LANDUSEF, Registry

SOURCE: Robert Gilliam, US EPA

DESCRIPTION OF CHANGES:
RA, RS, LANDUSEF, T2OBS and Q2OBS are not default in WRF output when the Pleim-Xiu LSM package is used.

Solution:
We changed the Registry to add "h" next to variable declarations and added these to the "package pxlsmscheme sf_surface_physics==7" definition.

ISSUE: N/A

LIST OF MODIFIED FILES:
Registry.EM_COMMON

TESTS CONDUCTED:

  1. We recompiled the code after clean -a and then ran a NOAH and P-X LSM simulation for a 3-hour run. Verified that P-X variables only show up in the WRF output when the Pleim-Xiu LSM is used. These variables were not in the NOAH run's output.
  2. No Jenkins testing

RELEASE NOTE: Pleim-Xiu updated so all variable used by CMAQ are put in WRF outputs.

@weiwangncar weiwangncar changed the base branch from master to develop March 21, 2024 16:49
@weiwangncar
Copy link
Collaborator

@coastwx Thanks for adding this. You can package RA and RS, but you cannot package LANDUSEF as other LSMs use it too. When you package something with a particular option, those arrays should only be used by that option alone.

@weiwangncar
Copy link
Collaborator

@coastwx I edited your file to remove landusef from package.

@weiwangncar
Copy link
Collaborator

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@coastwx
Copy link
Contributor Author

coastwx commented Mar 21, 2024 via email

@weiwangncar
Copy link
Collaborator

@coastwx @dudhia It looks like RS is passed into Noah LSM and set there too. So it cannot be packaged with PXLSM.

@dudhia
Copy link
Collaborator

dudhia commented Mar 26, 2024

I see RS also passed to NoahMP

@weiwangncar
Copy link
Collaborator

@dudhia Should we just package RA or should we let it go of this PR altogether?

@dudhia
Copy link
Collaborator

dudhia commented Mar 26, 2024

An alternative is to name them specially like RA_PX and RS_PX and package those. There is a precedent in that LSM.

@coastwx
Copy link
Contributor Author

coastwx commented Mar 26, 2024 via email

@dudhia
Copy link
Collaborator

dudhia commented Mar 26, 2024

Renaming could be confined to the model down to the driver with internal physics names the same as before, but yes the output names would be changed, so we can leave it as is.

@weiwangncar
Copy link
Collaborator

@coastwx Considering the complication of adding these variables to package, can we just not do this for now?

@coastwx
Copy link
Contributor Author

coastwx commented Mar 27, 2024

Sure. Disregard the pull request. I doubt there will be much enthusiasm to change the variable names in the WRF output. I'll discuss with our group and perhaps do this in later versions. It would require testing and the window is almost closed for this cycle. And we've gone many years the way it is now. Will update the PX LSM suggested run configuration document. I may be in touch very soon with an update to this hosted document.

https://www2.mmm.ucar.edu/wrf/users/docs/PX-ACM.pdf

@weiwangncar
Copy link
Collaborator

@coastwx Thanks. I will close this PR and we will see what a future solution might be. Please send us any update of the document, probably before the end of April if possible.

@coastwx coastwx deleted the PX_REGISTRY_UPDATE branch March 28, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants