Fix 3-domain restart by allowing climatological ozone interpolated to each nest domains in RRTMG #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and this corrects restart problem for 3 domains since 3.7.
mkavulich
approved these changes
Apr 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: ozone input, RRTMG
SOURCE: internal
DESCRIPTION OF CHANGES:
In this PR "failure" is defined as not being bit-for-bit when comparing a restart to the original run.
A restart problem using 3 domains was traced to using o3input = 2 option. This option interpolates climatological ozone onto coarse grid, and uses special mechanism (p2c) to interpolate it to the nest. This appears to work ok with 2 domain cases in restart, but fails 3-domain restart. The fix is to do interpolation directly onto each nest grids.
LIST OF MODIFIED FILES:
modified: phys/module_radiation_driver.F
TESTS CONDUCTED: Regtested with WTF-3.07 (with some PGI compilation failure due to ICENSE MANAGER PROBLEM. Tested on a case with and without this change.