New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example of how to add 4d arrays into ARW #528
Conversation
TYPE: no impact KEYWORDS: 4d arrays SOURCE: internal DESCRIPTION OF CHANGES: These mods are directed towards a user who would like to have a new 4d array that has the following qualifications: 1. Not in the lateral BC file 2. No tendency arrays auto-created 3. Not required for output 4. Physics only, column oriented, no comms, no advection or diffusion 5. Initialized either in real or WPS 6. No nesting requirement with the field 7. No restart requirements The new registry file has the following: 1. The 4d array container and the new constituent 3d arrays listed. 2. Namelist option to activate the fields 3. Package for the allocation of the new 4d arrays At the tail end of the real program, is an example location of where the initialization code could be located (if the information is not coming in from WPS). Commented out is the included new registry file in the EM shared collection. LIST OF MODIFIED FILES: M Registry/registry.em_shared_collection M Registry/registry.test_4d M dyn_em/module_initialize_real.F TESTS CONDUCTED: 1. Code builds 2. New fields are in the WRF input file.
@smileMchen |
@davegill |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
Do not want this accidentally merged - this is an example
@davegill @smileMchen |
@kkeene44 @smileMchen |
@davegill @smileMchen |
That (FAQ on Forum) seems to be a good place for something like this.
On Dec 12, 2018, at 9:07 AM, Kelly Werner <notifications@github.com> wrote:
@davegill <https://github.com/davegill> @smileMchen
<https://github.com/smileMchen>
Is this something we could put on the forum, as an FAQ-type thing? I can
attach files, etc. there if needed.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#528 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AMHfkKboYxVu9U4tbhKWWFDPfD6RE2b2ks5u4SnGgaJpZM4UBvyp>
.
|
Folks,
Maybe on the forum just have a link to the closed PR? I am OK with this or
putting all of the info on the forum.
Dave
On Wed, Dec 12, 2018 at 9:10 AM weiwangncar <notifications@github.com>
wrote:
… That (FAQ on Forum) seems to be a good place for something like this.
On Dec 12, 2018, at 9:07 AM, Kelly Werner ***@***.***>
wrote:
@davegill <https://github.com/davegill> @smileMchen
<https://github.com/smileMchen>
Is this something we could put on the forum, as an FAQ-type thing? I can
attach files, etc. there if needed.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#528 (comment)>, or
mute
the thread
<
https://github.com/notifications/unsubscribe-auth/AMHfkKboYxVu9U4tbhKWWFDPfD6RE2b2ks5u4SnGgaJpZM4UBvyp
>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#528 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AMFFegDz-No5kOSCeiQKTeZenvxgaweqks5u4SpggaJpZM4UBvyp>
.
|
I think it is better that the forum has a link to the PR. In this way people will get a full picture what they should do no matter what version of WRF they are working with. |
@smileMchen @davegill |
DO NOT COMMIT, EXAMPLE ONLY
TYPE: no impact
KEYWORDS: 4d arrays
SOURCE: internal
DESCRIPTION OF CHANGES:
These mods are directed towards a user who would like to have a new 4d array that has the following qualifications:
The new registry file has the following:
At the tail end of the real program, is an example location of where the initialization code could be located (if the information is not coming in from WPS).
Commented out is the included new registry file in the EM shared collection.
LIST OF MODIFIED FILES:
M Registry/registry.em_shared_collection
A Registry/registry.test_4d
M dyn_em/module_initialize_real.F
TESTS CONDUCTED:
New 3d constituent SINX of TEST4D
New 3d constituent COSY of TEST4D
New 3d constituent TANXY of TEST4D