Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example of how to add 4d arrays into ARW #528

Closed
wants to merge 3 commits into from
Closed

Example of how to add 4d arrays into ARW #528

wants to merge 3 commits into from

Conversation

davegill
Copy link
Contributor

@davegill davegill commented May 16, 2018

DO NOT COMMIT, EXAMPLE ONLY

TYPE: no impact

KEYWORDS: 4d arrays

SOURCE: internal

DESCRIPTION OF CHANGES:
These mods are directed towards a user who would like to have a new 4d array that has the following qualifications:

  1. Not in the lateral BC file
  2. No tendency arrays auto-created
  3. Not required for output
  4. Physics only, column oriented, no comms, no advection or diffusion
  5. Initialized either in real or WPS
  6. No nesting requirement with the field
  7. No restart requirements

The new registry file has the following:

  1. The 4d array container and the new constituent 3d arrays listed.
  2. Namelist option to activate the fields
  3. Package for the allocation of the new 4d arrays

At the tail end of the real program, is an example location of where the initialization code could be located (if the information is not coming in from WPS).

Commented out is the included new registry file in the EM shared collection.

LIST OF MODIFIED FILES:
M Registry/registry.em_shared_collection
A Registry/registry.test_4d
M dyn_em/module_initialize_real.F

TESTS CONDUCTED:

  1. Code builds
  2. New fields are in the WRF input file.

New 3d constituent SINX of TEST4D
screen shot 2018-05-16 at 11 30 13 am

New 3d constituent COSY of TEST4D
screen shot 2018-05-16 at 11 29 58 am

New 3d constituent TANXY of TEST4D
screen shot 2018-05-16 at 11 29 43 am

TYPE: no impact

KEYWORDS: 4d arrays

SOURCE: internal

DESCRIPTION OF CHANGES:
These mods are directed towards a user who would like to have a new 4d array that has the following qualifications:
1. Not in the lateral BC file
2. No tendency arrays auto-created
3. Not required for output
4. Physics only, column oriented, no comms, no advection or diffusion
5. Initialized either in real or WPS
6. No nesting requirement with the field
7. No restart requirements

The new registry file has the following:
1. The 4d array container and the new constituent 3d arrays listed.
2. Namelist option to activate the fields
3. Package for the allocation of the new 4d arrays

At the tail end of the real program, is an example location of where the initialization code could be located (if the information is not coming in from WPS).

Commented out is the included new registry file in the EM shared collection.

LIST OF MODIFIED FILES:
M	   Registry/registry.em_shared_collection
M	   Registry/registry.test_4d
M	   dyn_em/module_initialize_real.F

TESTS CONDUCTED:
1. Code builds
2. New fields are in the WRF input file.
@davegill
Copy link
Contributor Author

@smileMchen
Ming,
Is this a good example?

@smileMchen
Copy link
Collaborator

@davegill
Yes it answers the question. Thank you very much!

smileMchen
smileMchen previously approved these changes May 16, 2018
Copy link
Collaborator

@smileMchen smileMchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@davegill davegill changed the base branch from master to develop September 26, 2018 14:11
@davegill davegill dismissed smileMchen’s stale review October 29, 2018 18:20

Do not want this accidentally merged - this is an example

@kkeene44
Copy link
Collaborator

@davegill @smileMchen
Does this need to stay in here as a PR, or was the intention to eventually move it elsewhere?

@davegill
Copy link
Contributor Author

@kkeene44 @smileMchen
Kelly,
I am not sure where to put this. The github diffing makes it easy for users to see what they are supposed to do. We can close it, and just come back to it when we want. I'd be OK with that.

@davegill davegill closed this Dec 12, 2018
@kkeene44
Copy link
Collaborator

@davegill @smileMchen
Is this something we could put on the forum, as an FAQ-type thing? I can attach files, etc. there if needed.

@weiwangncar
Copy link
Collaborator

weiwangncar commented Dec 12, 2018 via email

@davegill
Copy link
Contributor Author

davegill commented Dec 12, 2018 via email

@smileMchen
Copy link
Collaborator

I think it is better that the forum has a link to the PR. In this way people will get a full picture what they should do no matter what version of WRF they are working with.

@kkeene44
Copy link
Collaborator

@smileMchen @davegill
Agreed. I will do that sometime today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants