Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

628 table attribute table #661

Merged
merged 10 commits into from
Nov 11, 2019
Merged

Conversation

KaylaKremer
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #628

What is the new behavior?

  • Adds the mapLayerId to URLs generated in the CMS in order to retrieve the table attribute data.

Does this introduce a breaking change?

  • Yes
  • No

Other information

This is a CMS specific issue and needs to be tested out!

@KaylaKremer KaylaKremer changed the base branch from master to sprint-6-base November 4, 2019 20:08
Copy link
Contributor

@SwampGuzzler SwampGuzzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This succeeds in this particular build but breaks attribute tables in other countries. For an example, see this config: 43548e1

@KaylaKremer
Copy link
Contributor Author

KaylaKremer commented Nov 5, 2019

Copy link
Contributor

@SwampGuzzler SwampGuzzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this up to the CMS to test CMR and DRC --> we still need to understand why the features in the Georgia application have a _layer.id property of layers that aren't Really in the map at all: PA_4 vs PA

@SwampGuzzler SwampGuzzler merged commit 1eae738 into sprint-6-base Nov 11, 2019
@SwampGuzzler SwampGuzzler deleted the 628-table-attribute-table branch November 11, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants