GTC-2889 Remove code in FCD related to geometry diffs and intermediate results #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e results We've been ignoring geometry diffs (location id == -2) for a long time, and we never pass in any intermediate results. By removing this code, we avoid computing the centroid of each location geometry, inserting it into the feature id, then removing it from the feature id without having used it at all. Move the only remaining code from combineGridResults() into the main function. Also, we had a duplicate call to data.withUpdatedCommodityRisk() in combineGridResults(), so got rid of that (already called data.withUpdatedCommodityRisk() in main analysis code above). The test change was just a change in order of categories within a single result, which is no actual change of the results.
jterry64
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GTC-2889 Remove code in FCD related to geometry diffs and intermediate results
We've been ignoring geometry diffs (location id == -2) for a long time, and we never pass in any intermediate results.
By removing this code, we avoid computing the centroid of each location geometry, inserting it into the feature id, then removing it from the feature id without having used it at all.
Move the only remaining code from combineGridResults() into the main function. Also, we had a duplicate call to
data.withUpdatedCommodityRisk() in combineGridResults(), so got rid of that (already called data.withUpdatedCommodityRisk() in main analysis code above).
The test change was just a change in order of categories within a single result, which is no actual change of the results.