Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include collection and id in postparams #18

Merged
merged 1 commit into from Jun 13, 2019

Conversation

Projects
None yet
2 participants
@robjloranger
Copy link
Member

commented Jun 12, 2019

this changes the JSON tags to include both the ID and Collection
in PostParams. Both will be omitted when empty to maintain any unknown
backwards compatibility.

include collection and id in postparams
this changes the JSON tags to include both the ID and Collection
in PostParams. Both will be omitted when empty to maintain any unknown
backwards compatibility.

@robjloranger robjloranger requested a review from thebaer Jun 12, 2019

@robjloranger robjloranger removed the request for review from thebaer Jun 13, 2019

@robjloranger robjloranger merged commit 8463946 into master Jun 13, 2019

@robjloranger robjloranger deleted the include-coll branch Jun 13, 2019

@thebaer

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

Just want to make sure I understand the rationale for this. I left a comment on T645

thebaer added a commit that referenced this pull request Jun 13, 2019

Revert "Merge pull request #18 from writeas/include-coll"
This reverts commit 8463946, reversing
changes made to 8cf5d50.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.