ref T586 support any writefreely instance #36

ghost · 2019-06-11T22:52:19Z

This one is a bit huge.

First this creates a new binary wf which supports additional features not needed on write.as. Namely different hosts and multiple users, as many user accounts can be authenticated as you wish. Just pass a -u <username> global flag to select the one to use for an action. i.e. wf -u rob posts

This would be v1.0 for wf.

ref T592, T593, T594, T595, T597, T634, T635, T645

ghost · 2019-06-11T22:53:25Z

~~also will need to verify the change with global flags doesn't break anything~~
fixed

ghost · 2019-06-12T00:12:24Z

found a small bug I missed, unsynced posts are stored in one file at the root, not at each host level. fix incoming.

ghost · 2019-06-12T19:41:58Z

just waiting for writeas/go-writeas#18 to verify things work as expected

this creates a second binary, wf, which will have additonal functionality for hosts other than write.as. also moves global flags into their own slice in new file adds `host, H` global flag inlcudes gitignore for binary

only if host flag supplied for writefreely binary, writeas unaffected

some changes resulted in the data directory initialization creating the .writeas/.writefreely directory in the current working directory.

- adds new user/u flag to wf - load and save user file based on username - removed host flag from writeas - adds hidden global flag for user to writeas to maintain compatibility

- now allows authentication with more than one user per host, stored as username.json inside the [host] directory. - supports a default user and host in config.ini - global flags will override the default

full support, auth and actions working by use of flags or defaults maintains backwards compatibility with write.as

this get's the wf binary up to date with the writeas functionality

only on wf, writeas still stores in root user config directory

there was a bug where a default user at the config directory root was not being used for calls not including a flag or host level config.ini

also update CmdClaim for new LoadUser signiture

I had changed the global flags variable to only be those that are global this broke some compatibility with piping from stdout into the binary. also: - binary specific configuration details have moved into the same map but in main.go. only the configDir is OS dependent. - a new key in the map is for the version so each binary can have their own

also CmdPost should return an exit error if there is one

for inclusion of collection in post parameters

new posts, when no flag is specified for blog or collection, will now default to the user collection. that is the username.

if the user flag is provided auth should attempt to authenticate with that user.

ghost · 2019-08-08T17:31:46Z

ready for final testing and review @thebaer

thebaer · 2019-09-09T15:54:53Z

Okay, we're getting very close. This may be the last issue we need to solve. The situation is:

I'm logged in under multiple accounts, but don't have a default user set (I logged out of it, so it was removed from the config). Now when I run ./wf I get:

You must be authenticated to publish.
Log in first with: wf auth <username>

This is confusing, because I am authenticated -- wf just doesn't know what account to use, since there's no default and no flags given. So instead, I'd like it to say something like:

You are authenticated, but have no default user set. Supply -user and -host flags.

I started trying to implement this, but it looks like it's going to need a bit more work. It looks like we're getting very close to needing the accounts command. If that logic is needed to get this error message, then we should do it.

What do you think?

ghost · 2019-09-09T16:03:53Z

I'll take a look quick, we might be able to get this without adding the accounts command, then add that after. Unless you want it all in for the CLI release.

thebaer · 2019-09-09T16:05:32Z

Let's try to go without it for this initial release and add it later.

ghost · 2019-09-09T16:31:39Z

ok got it, just going to clean up some redundancy quick

this adds a check for any logged in users on any host when neither the user or host flag are passed and not default pair is configured

ghost · 2019-09-09T16:38:35Z

I didn't bother to refactor, it would only save three lines in two places.

thebaer · 2019-09-09T16:45:22Z

Awesome, will test when I'm back at my computer.

thebaer · 2019-09-09T19:38:57Z

Just tested latest changes and now I'm unable to post anything:

$ echo "hi" | ./wf -host team.write.as
Unable to post: Problem creating post: 401. Not logged in.
$ echo "hi" | ./wf -host team.write.as -user matt
Unable to post: Problem creating post: 401. Not logged in.

To be sure, I'm authenticated as matt on team.write.as. Is everything working for you?

thebaer · 2019-09-09T19:42:34Z

Also some odd behavior when I do have a default account:

$ ./wf -host pencil.writefree.ly auth hello
Password: *******
Set hello on pencil.writefree.ly as default account.
$ echo "hi" | ./wf
Error creating data directory: mkdir /home/mattbaer/.writefreely/https:/pencil.writefree.ly: no such file or directory
You must be authenticated to publish.
Log in first with: wf auth <username>

Probably because we store the schema in the configuration. Which is probably correct, e.g. if someone logs in with the --insecure flag we should respect that. But then when loading the default from the config file, we shouldn't prepend any schema. Could you take a look at that?

this changes DoUpdate and DoDelete to load the user and set the access token in the client when no edit token is provided.

thebaer · 2019-09-18T20:36:21Z

Looks really, really good!

I think the very last thing is that we should undo the change where wf automatically posts to the logged in user's default collection (i.e. the one that matches their username). It's convenient, but it makes publishing drafts impossible, so we should fix that.

I also fixed some weird language when trying to run commands while being unauthenticated.

ghost · 2019-09-18T21:07:51Z

Sure, I can revert the default collection thing.

thebaer · 2019-09-18T21:25:42Z

Great. Though now I don't seem to be able to post at all:

Unable to post: Problem creating post: 401. Not logged in.

ghost · 2019-09-18T21:35:21Z

silly question, are you logged in? I tried with both wf and writeas with success. using the default command, and new. which sub command are you using?

thebaer · 2019-09-18T21:47:08Z

Hmm yeah, I authenticated right after I pulled in those changes. But then I re-authenticated with the same exact account and now it's all working. Weird. But draft publishing works 👍

Doing one last run-through and then we'll merge!

thebaer · 2019-09-20T15:32:59Z

There are still some very small places where we can improve the UX, but we can address them in the next update. Great work! Merging now.

ghost marked this pull request as ready for review June 11, 2019 23:34

ghost changed the title ~~ref T586 support any writefreely instance~~ [WIP] ref T586 support any writefreely instance Jun 12, 2019

ghost changed the title ~~[WIP] ref T586 support any writefreely instance~~ ref T586 support any writefreely instance Jun 13, 2019

ghost requested a review from thebaer June 13, 2019 17:18

Rob Loranger added 20 commits June 18, 2019 14:56

add new wf binary for community instances

ece87e9

this creates a second binary, wf, which will have additonal functionality for hosts other than write.as. also moves global flags into their own slice in new file adds `host, H` global flag inlcudes gitignore for binary

add helper to parse host based config dir

834bc2a

remove unused global flags

35292d2

use global flags in writeas cli

30ecf6c

store/load user with host specific sub folder

d6c4b2c

only if host flag supplied for writefreely binary, writeas unaffected

delete host specific user when doing logout

79aae31

fix bug with creating empty dir in working dir

be060d7

some changes resulted in the data directory initialization creating the .writeas/.writefreely directory in the current working directory.

start multi user authentication

33578e8

- adds new user/u flag to wf - load and save user file based on username - removed host flag from writeas - adds hidden global flag for user to writeas to maintain compatibility

multiple user authentication

15f71e3

- now allows authentication with more than one user per host, stored as username.json inside the [host] directory. - supports a default user and host in config.ini - global flags will override the default

support any writefreely instance

20919fb

full support, auth and actions working by use of flags or defaults maintains backwards compatibility with write.as

wf: remove fetch and add blogs cmd

5855fd3

this get's the wf binary up to date with the writeas functionality

store user.json in user sub folder

d10b3ee

only on wf, writeas still stores in root user config directory

bugfix: default user should work on other domains

ea3e57a

there was a bug where a default user at the config directory root was not being used for calls not including a flag or host level config.ini

include new claim cmd in wf

5720440

also update CmdClaim for new LoadUser signiture

include new claim cmd and host/user flag in docs

d7e477a

local posts should use host dir

844ce07

also CmdPost should return an exit error if there is one

use v2.0.1 go-writeas

2412d21

for inclusion of collection in post parameters

default to user collection

3f8b0d0

new posts, when no flag is specified for blog or collection, will now default to the user collection. that is the username.

revert to go-writeas v2.0.0

c7bff5e

ghost force-pushed the T586 branch from 8e49509 to c7bff5e Compare June 18, 2019 21:57

ghost changed the base branch from version-two to develop June 18, 2019 21:57

Merge branch 'develop' into T586

498a3af

command auth should use user flag

6dbf4f9

if the user flag is provided auth should attempt to authenticate with that user.

check for any logged in user when no flag passed

d8d41a9

this adds a check for any logged in users on any host when neither the user or host flag are passed and not default pair is configured

remove println

284087a

Rob Loranger added 7 commits September 9, 2019 13:07

set token on new client for api post

86e9757

fix user auth for writeas posting

96f57d5

fix hostname schema dir issues

83bc1cf

clean up CurrentUser global cfg logic

024b709

get tokens for update and delete

b60ae1e

this changes DoUpdate and DoDelete to load the user and set the access token in the client when no edit token is provided.

fix post url for non standard hostnames

05380e6

wf/post list: draft posts not anonymous

47d8bb3

ghost mentioned this pull request Sep 13, 2019

add accounts command #44

Merged

Fix un-auth'd messages on various commands

1123705

remove default collection of username

ff67ed2

thebaer merged commit de2ec24 into develop Sep 20, 2019

thebaer deleted the T586 branch September 20, 2019 15:37

ref T586 support any writefreely instance #36

ref T586 support any writefreely instance #36

Uh oh!

Conversation

ghost commented Jun 11, 2019 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jun 11, 2019 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jun 12, 2019 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jun 12, 2019

Uh oh!

ghost commented Aug 8, 2019

Uh oh!

thebaer commented Sep 9, 2019

Uh oh!

ghost commented Sep 9, 2019

Uh oh!

thebaer commented Sep 9, 2019

Uh oh!

ghost commented Sep 9, 2019

Uh oh!

ghost commented Sep 9, 2019

Uh oh!

thebaer commented Sep 9, 2019

Uh oh!

thebaer commented Sep 9, 2019

Uh oh!

thebaer commented Sep 9, 2019

Uh oh!

thebaer commented Sep 18, 2019

Uh oh!

ghost commented Sep 18, 2019

Uh oh!

thebaer commented Sep 18, 2019

Uh oh!

ghost commented Sep 18, 2019 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thebaer commented Sep 18, 2019

Uh oh!

thebaer commented Sep 20, 2019

Uh oh!

Uh oh!

ghost commented Jun 11, 2019 •

edited by ghost

Loading

ghost commented Jun 11, 2019 •

edited by ghost

Loading

ghost commented Jun 12, 2019 •

edited by ghost

Loading

ghost commented Sep 18, 2019 •

edited by ghost

Loading