New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List files in Clean Data & Sync From Data #273
Comments
@Infernio & @Utumno : This commit on today's nightly branch handles this need. It displays a sorted list of untracked files using checkboxes. |
Thanks! Left a preliminary review (code style only) on your commit. |
Pushed an update with requested changes. Probably should be squished later but preserving history now. |
Left a few more nits, mostly line wrapping. Do you have your editor configured to show a 79-chars boundary? Very useful when writing WB code. |
I'm using PyCharm but was set to show a 120-char boundary so didn't see that when I scrolled. I've set it to 79 and now see all the offenders. I also see a lot of existing code exceeding that boundary. Those must be legacy and slowly be reworked. I personally think sometimes going a little beyond a 79 char boundary leads to more readable code or might incentivize using less descriptive names. For example, in bain.py (nightly branch) line's 2647 & 2648 exceed 79 chars and is more readable as-is IMO than wrapping.
However that's not the consensus in the python community and having said that I'll fix it to standards and not mention it again. :) I see I didn't study the code enough to notice I could use |
Yup, code that goes beyond 79 is generally old. New code should always stick to PEP8. The bain example looks OK, but I think this alternative which fits into 79 chars isn't that much worse (the symmetry of having the string line up is actually pretty nice): showInactive = conflicts_mode and bass.settings[
'bash.installers.conflictsReport.showInactive']
showLower = conflicts_mode and bass.settings[
'bash.installers.conflictsReport.showLower']
showBSA = bass.settings[
'bash.installers.conflictsReport.showBSAConflicts'] Anyway, yes this is off-topic chatter :) |
This commit should met your request. It needs to be squashed later.
I assume there is something wrong with my local setup but stopped going down that rabbit hole after investigating a while. Does Dump Translator work off nightly for you? |
No need to actually translate the strings, just surround them with an |
Let the user edit the list and keep any file in the Data folder. @Infernio handles wrye-bash#273.
Style looks fine now :) The two wrye-bash/Mopy/bash/bosh/bain.py Lines 2557 to 2560 in 10e680c
wrye-bash/Mopy/bash/bosh/bain.py Lines 2565 to 2566 in 10e680c
So moving that part up into |
Rebased on latest nightly, updated and ready for review. |
We keep Bashed Patch docs for all BPs that are in the Data folder. So if you have a |
I noticed my error after I posted that comment so I edited and removed. Bad practice to remove part of a comment once published since your comment now refers to "nothing". My bad. :( Next time I'll show EDIT: instead. |
Was just wondering why it was trying to remove diff --git a/Mopy/bash/game/fallout3/__init__.py b/Mopy/bash/game/fallout3/__init__.py
index c94abc3f1..f9a0d9396 100644
--- a/Mopy/bash/game/fallout3/__init__.py
+++ b/Mopy/bash/game/fallout3/__init__.py
@@ -106,7 +106,7 @@ class Xe(GameInfo.Xe):
}
SkipBAINRefresh = {u'fo3edit backups', u'fo3edit cache'}
wryeBashDataFiles = GameInfo.wryeBashDataFiles | {
- u'ArchiveInvalidationInvalidated!.bsa'
+ u'ArchiveInvalidationInvalidated!.bsa',
u'Fallout - AI!.bsa'
}
ignoreDataFiles = { You could include that in your commit as a quick fixup :) |
Nice catch. Technically that change is not directly related to the Clean Data code. It's a result of Clean Data now displaying files to the user. However I can make that change and include it in the commit if you want. |
You can include it and add a small note like this in the commit msg:
That's generally what we do if we have a tiny commit that doesn't have much value on its own. Edit: you can see an example here: 5c7772a |
Done. warmfrost85@387fe05 |
Did you see my comments I left on warmfrost85@a30ab8b? Once those are addressed, then I think this is ready for testing - I'll pull it over and stick it on nightly/307-beta6 here :) |
Let me do that - although turns out the difficult part is this: https://bugs.python.org/issue7195 |
Sorry, I missed your comments. Now updated. Is there such a thing as Done. Done. ? :) |
@Utumno Do you have your BP docs on a different drive? If so, checking if the Data folder is part of the BP doc path should be enough, right? If something isn't in the data folder, then BAIN has no business trying to clean it. |
Yes - good one :)
What's even stranger though is that when I run pycharm debugger it will silently fail - won't even show the dialog. A heisenbug ? :D |
See: https://sourceforge.net/p/oblivionworks/enhancements/162/, https://sourceforge.net/p/oblivionworks/enhancements/113/, https://sourceforge.net/p/oblivionworks/enhancements/220/
Do see those for ideas etc
At least prompt before sync from data - quoting @saebel:
From 162:
From 220:
The text was updated successfully, but these errors were encountered: