Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wslu is not taking DESTDIR into account when loading config file #264

Closed
1 task done
SuperSandro2000 opened this issue Jan 20, 2023 · 1 comment
Closed
1 task done

wslu is not taking DESTDIR into account when loading config file #264

SuperSandro2000 opened this issue Jan 20, 2023 · 1 comment
Assignees
@patrick330602
Labels
Bug This is either an issue that describes a bug or a PR that resolves a bug Status: Patched This is fixed and is part of a released version. Target: 4.x This is targeted to the 4.x release.

Comments

@SuperSandro2000
Copy link

Windows Version

Windows 11

Windows Build Number

10.0.22621.1105

WSL Version

WSL 2

Distro Version

NixOS

WSL Utilities Version

4.1.1

Describe the bug

NixOS is using DESTDIR variable to install the conf file into a none standard location (eg /nix/store/f9w6sa74xk0hymrbz2mrm4r9hfvns6fp-wslu-4.1.1/etc/wslu/conf). By default utilities like wslvar will not find it and miss a default value for WSLVAR_DEFAULT_VARTYPE, those a command like wslvar USERNAME fails with [error] Invalid variable type. Aborted..

Steps to Reproduce

Run the following on NixOS unstable in WSL.

$ wslvar USERNAME
[error] Invalid variable type. Aborted.

Expected behavior

DESTDIR should be used to find the fallback config in the nix store if the usual locations do not yield a result.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@SuperSandro2000 SuperSandro2000 added the Bug This is either an issue that describes a bug or a PR that resolves a bug label Jan 20, 2023
@patrick330602
Copy link
Member

Interesting... I will take a look recently

@patrick330602 patrick330602 added the Target: 4.x This is targeted to the 4.x release. label Jan 23, 2023
patrick330602 added a commit that referenced this issue Nov 12, 2023
@patrick330602
fix: [#264] make DESTDIR properly configured in header
b6fa4b7
@patrick330602 patrick330602 added the Status: Pending Release This is fixed but not yet released. label Nov 12, 2023
@patrick330602 patrick330602 mentioned this issue Dec 31, 2023
Merged
@patrick330602 patrick330602 added Status: Patched This is fixed and is part of a released version. and removed Status: Pending Release This is fixed but not yet released. labels Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patrick330602 patrick330602

Labels
Bug This is either an issue that describes a bug or a PR that resolves a bug Status: Patched This is fixed and is part of a released version. Target: 4.x This is targeted to the 4.x release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SuperSandro2000 @patrick330602