Ibmmqconnector #1
Conversation
| @@ -0,0 +1,33 @@ | |||
| <!DOCTYPE suite SYSTEM "http://testng.org/testng-1.0.dtd" > | |||
| <!-- | |||
| ~ Copyright (c) 2016, WSO2 Inc. (http://www.wso2.org) All Rights Reserved. | |||
There was a problem hiding this comment.
Please correct the license header to 2017 license header
| @@ -0,0 +1,38 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!-- | |||
| Copyright (c) 2016, WSO2 Inc. (http://www.wso2.org) All Rights Reserved. | |||
There was a problem hiding this comment.
Please correct the license header to 2017 license header
| import java.util.Collection; | ||
| import java.util.Vector; | ||
|
|
||
| /** |
There was a problem hiding this comment.
Remove the current Java Doc and add a descriptive one
| @@ -0,0 +1,32 @@ | |||
| package org.wso2.carbon.esb.connector; | |||
|
|
|||
There was a problem hiding this comment.
Remove the current Java Doc and add a descriptive one
| import org.wso2.carbon.connector.core.ConnectException; | ||
|
|
||
| /** | ||
| * Created by hasitha on 6/30/17. |
There was a problem hiding this comment.
Remove the current Java Doc and add a descriptive one
| @@ -0,0 +1,239 @@ | |||
| package org.wso2.carbon.esb.connector; | |||
|
|
|||
There was a problem hiding this comment.
Please add wso2 licence header to each file
src/main/java/org/wso2/carbon/esb/connector/MQPublishTopic.java
Outdated
Show resolved
Hide resolved
src/main/java/org/wso2/carbon/esb/connector/MQPublishTopic.java
Outdated
Show resolved
Hide resolved
src/main/java/org/wso2/carbon/esb/connector/MQPublishTopic.java
Outdated
Show resolved
Hide resolved
src/main/java/org/wso2/carbon/esb/connector/MQReportConstants.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * Sample integration test | ||
| */ | ||
| public class ibmmqIntegrationTest extends ConnectorIntegrationTestBase { |
|
Please note you should remove all the proprietary IBM binary files committed from the PR. |
src/main/java/org/wso2/carbon/esb/connector/MQConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/org/wso2/carbon/esb/connector/MQConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/org/wso2/carbon/esb/connector/MQConfiguration.java
Outdated
Show resolved
Hide resolved
|
What if we have only a few meaningful commits in the PR? You may squash commits in the following manner: |
… the result Code cleaned up changed method synchronization Removed ConcurrentHashmap Added Queue Manager disconnect method Removed producerType configuration parameter Removed keystore parameters Init.xml changed for removed ssl parameters Added report replyToQueue and repalyToQueueManager parameters for report messages Message Type parameter changed
ibm-mq-connector for wso2 esb