Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiAttributeSeperator always overriden by DefaultClaimHandler #2379

Closed
ruwanta opened this issue Aug 21, 2019 · 1 comment
Closed

MultiAttributeSeperator always overriden by DefaultClaimHandler #2379

ruwanta opened this issue Aug 21, 2019 · 1 comment

Comments

@ruwanta
Copy link
Contributor

ruwanta commented Aug 21, 2019

Description:
DefaultClaimHandler always set the MultiAttributeSeperator as "comma" (system default). This can not be thus change by any other means, including Adaptive Authentication.

            String claimSeparator = realmConfiguration.getUserStoreProperty(IdentityCoreConstants
                    .MULTI_ATTRIBUTE_SEPARATOR);
            if (StringUtils.isNotBlank(claimSeparator)) {
                spRequestedClaims.put(IdentityCoreConstants.MULTI_ATTRIBUTE_SEPARATOR, claimSeparator);
            }

Change it to use "putIfAbsent"
ruwanta pushed a commit to ruwanta/carbon-identity-framework that referenced this issue Aug 21, 2019
Fixing issues:
92b6df3 
1. JS Functions, Getting current tenant domain by context instead of threadlocal
2. MultiAttributeSeperator always overriden by DefaultClaimHandler

wso2#2377
wso2#2379
@ruwanta ruwanta mentioned this issue Aug 21, 2019
Merged
19 tasks
@denuwanthi denuwanthi mentioned this issue Aug 22, 2019
Open
@ruwanta
Copy link
Contributor Author

ruwanta commented Aug 22, 2019

Closing as the fix done in master
#2382

@ruwanta ruwanta closed this as completed Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ruwanta