Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve function library validations #3735

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

janakamarasena
Copy link
Member

@janakamarasena janakamarasena commented Sep 17, 2021

Proposed changes in this pull request

Improve function library validations

When adding the loop validation code we checked the best place to have the code. This code would be used in application management when adding/updating an SP and also in functional script management when adding/updating a script. The options considered for the placement of the common code was.

  • Extract nashorn related code to a new component - But with the new improvements the function library will not have any nashorn related code
  • Add to Identity Base - Identity base is a common dependency for both components and contains a validation utility class. But the validation utilities currently available there serves a broader scope and adding the loop validation here will not have any usage for other components.
  • Adding application management common as a dependency to functional scripts component - Since logically functional scripts will only be used in applications, it seemed correct to go with this option and have the validation code in the application management common component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants