Modify the application patch and get requests to skip the organization role association #604
Conversation
|
Hasanthi Dissanayake seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
| if (associatedRoles != null) { | ||
| allowedAudience = associatedRoles.getAllowedAudience(); | ||
| List<Role> listRole = associatedRoles.getRoles(); | ||
| if (AssociatedRolesConfig.AllowedAudienceEnum.ORGANIZATION.equals(allowedAudience) | ||
| && !listRole.isEmpty()) { | ||
| throw buildClientError(ErrorMessage.INVALID_ROLE_ASSOCIATION_FOR_ORGANIZATION_AUDIENCE); | ||
| } | ||
| } |
There was a problem hiding this comment.
Can't we make allowedAudience is the only editable param of AssociatedRolesConfig object?
associatedRoles will be only a readonly attribute
for applicationAudience apps -> return the created App audienced roles, association will be built when creating the app audienced roles
for organizationAudiece apps -> return nothing
There was a problem hiding this comment.
For organizationAudiece apps, we need to return all the organization roles available in the organization regardless of the audience.
…n role association
...n/identity/api/server/application/management/v1/core/ServerApplicationManagementService.java
Show resolved
Hide resolved
...i/server/application/management/v1/core/functions/application/ServiceProviderToApiModel.java
Show resolved
Hide resolved
|
PR builder started |
|
PR builder completed |
|
PR builder started |
|
PR builder completed |
Modify the application patch and get requests to skip the organization role association