Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge common module code into admin.core.v1 #5883

Merged
merged 7 commits into from
Apr 3, 2024

Conversation

jathushan-r
Copy link
Contributor

Purpose

There were identical pieces of code ("duplicates") found in modules/common and features/admin.core.v1. merged the additional codes from modules/common into features/admin.core.v1, and removed @wso2is/common module dependencies from apps/console and features. These changes streamline project structure, and enhance maintainability.

Related Issues

Related PRs

Checklist

  • e2e cypress tests locally verified.
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

@jathushan-r jathushan-r marked this pull request as ready for review April 3, 2024 10:51
@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@brionmario brionmario merged commit 0ae8df8 into wso2:master Apr 3, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants