Introduce ThemeProvider for styling across Features package
#6173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jathushan-r
force-pushed
the
feature/features-branding
branch
3 times, most recently
from
52438dc
to
5b454d3
Compare
jathushan-r
force-pushed
the
feature/features-branding
branch
4 times, most recently
from
3010928
to
4609d36
Compare
jathushan-r
force-pushed
the
feature/features-branding
branch
from
651b7a8
to
e698ee6
Compare
jathushan-r
changed the title
Features package.Features package
jathushan-r
changed the title
Features packageFeatures package
jathushan-r
changed the title
Features packageFeatures package
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
JayaShakthi97
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR addresses an identified issue regarding inconsistent branding and styling when utilizing both Oxygen-UI and Semantic UI React. The implementation introduces a ThemeProvider within common.branding.v1. injecting CSS, it ensures seamless integration of branding elements across the applications.
Related Issues
product-is: Admin features in identity-server repository are tightly coupled with the Console application product-is#20119Related PRs
identity-apps: Move Console'sfeaturemodules outside to be re-usable cross applications #5849Checklist
Security checks