Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configs to feature packages #6332

Merged
merged 13 commits into from
May 22, 2024
Merged

Conversation

thiva-k
Copy link
Contributor

@thiva-k thiva-k commented May 21, 2024

Purpose

Add tsconfig.json and rollup.config.cjs to each feature package.
Add react, react-dom and react-router-dom as peer-dependencies to feature packages.
Add script to bundle each feature individually.

Related Issues

Related PRs

Checklist

  • e2e cypress tests locally verified.
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

@thiva-k thiva-k marked this pull request as ready for review May 21, 2024 13:18
JayaShakthi97
JayaShakthi97 previously approved these changes May 21, 2024
@thiva-k thiva-k marked this pull request as draft May 21, 2024 14:55
@thiva-k thiva-k marked this pull request as ready for review May 21, 2024 16:41
@wso2-jenkins-bot
Copy link
Contributor

⚠️ No Changeset found

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.

If these changes should result in a version bump, you need to add a changeset.

Refer Release Documentation to learn how to add a changeset.

@JayaShakthi97 JayaShakthi97 merged commit 8e540e4 into wso2:master May 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants