Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): create a React Icons package #6

Merged
merged 14 commits into from
Feb 6, 2023

Conversation

brionmario
Copy link
Member

@brionmario brionmario commented Feb 4, 2023

Purpose

We needed a React wrapper around the SVG available in the primitives package.

Goals

  • Create a @oxygen-ui/react-icons package.
  • React package should not duplicate the SVGs rather use them from @oxygen-ui/primitives.
  • The approach should be extensible so that we can create any other framework specific packages in the future.
    • Ex:
      • @oxygen-ui/node-icons
      • @oxygen-ui/vue-icons
      • @oxygen-ui/angular-icons

Approach

  • Build and export the SVG data as a JSON from @oxygen-ui/primitives
  • Consume it from the @oxygen-ui/react-icons package and create react components from those SVGs.

oxygen-ui-icons-build-process

@brionmario brionmario merged commit 5d30bab into wso2:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants