feat(react): add PhoneNumberInput component
#64
Conversation
| src={`https://flagcdn.com/${country.code.toLowerCase()}.svg`} | ||
| srcSet={`https://flagcdn.com/${country.code.toLowerCase()}.svg 2x`} |
There was a problem hiding this comment.
Using a CDN in a library does not seem right to me. Can we try using flag emojis?
https://dev.to/jorik/country-code-to-flag-emoji-a21
There was a problem hiding this comment.
Emojis might have some issues in Windows. Maybe we can try a well maintained SVG flag library.
There was a problem hiding this comment.
Added react-world-flags package
|
|
||
| export interface Country { | ||
| code: string; | ||
| dialCode: string; |
There was a problem hiding this comment.
I didn't use countryCode as it could also be interpreted as the country's ISO country code. Can use phoneCode or the key names used in the MUI example : E.g. { code: 'AI', label: 'Anguilla', phone: '1-264' } - https://mui.com/material-ui/react-autocomplete/#country-select WDYT?
I got the list of codes from here with a few updates to values.
There was a problem hiding this comment.
GPT gave the following. dialCode would be fine i guess. @thivi any ideas here?
The technical term for a country dial code is "International Dialing Code" or "Country Calling Code".There was a problem hiding this comment.
Country Calling Codes or Country Dial-in Codes seems to be the standard.
https://en.wikipedia.org/wiki/List_of_country_calling_codes
…ui-1 into feat-phone-number-input
|
|
||
| export interface Country { | ||
| code: string; | ||
| dialCode: string; |
There was a problem hiding this comment.
Country Calling Codes or Country Dial-in Codes seems to be the standard.
https://en.wikipedia.org/wiki/List_of_country_calling_codes
Purpose
Add
PhoneNumberInputcomponent.Related Issues
Related PRs
Checklist
Security checks