B2B sample app improvements #405

sadilchamishka · 2023-03-11T16:32:05Z

Purpose

$subject

sadilchamishka · 2023-03-11T16:35:18Z

b2b-sample/README.md

@@ -47,6 +47,8 @@ Now we need **two** applications to communicate with the **Guardio-Business-App*

 Create two applications named **Guardio-Business-App** and **Guardio-Admin-App** [This should be a management application].

+Share both applications with all the organizations by clicking the share button.


There was no place mentioning about application sharing. Also the applications have to be shared at the moment of creation to view the organization_switch grant.

sadilchamishka · 2023-03-11T16:36:24Z

b2b-sample/README.md

-* Also, On the User Attributes tab, click on + Add User Attributes.
-    * Select `Email`, `First Name`, `Last Name`, and `Username` from the list of attributes.


This section is not related to this step and moved to the top after the admin app creation.

sadilchamishka · 2023-03-11T16:37:07Z

b2b-sample/README.md

@@ -65,6 +67,9 @@ Select `Email`, `First Name`, `Last Name`, and `Username` from the list of attri
 >| Authorized redirect URLs | `http://localhost:3001/api/auth/callback/wso2isAdmin` and `http://localhost:3001` |
 >| Allowed origin           |                           `http://localhost:3001`                            |

+Also, On the User Attributes tab, click on + Add User Attributes.
+Select `Email`, `First Name`, `Last Name`, and `Username` from the list of attributes.
+


Moved from bottom as mentioned in this comment

sadilchamishka · 2023-03-11T16:40:34Z

b2b-sample/README.md

-    "ApplicationConfig": {
-      "SampleOrganization": [
-        {
-          "id": "<SUB ORGANIZATION ID>",
-          "name": "<SUB ORGANIZATION NAME>"
-        }
-      ]


These configs are not required as user_organization claim is present in the ID token. The IS distributions with B2B feature where the user_organization claim is not presented can be affected due to removing this config. But we can suggest the previously released b2b-sample app for them to use, while keeping the latest b2b sample app up to date with latest changes without unnecessary configurations which can mislead the users.

Initial release of the b2b app - https://github.com/wso2/samples-is/releases/download/v4.5.3/b2b-sample.zip

Rather removing the configurations shall we update the readme with the proper description? Because as Sadil mentioned the sample will not work with IS distributions. This can be a problem when we release the GAs.

The developers would ask why we need this configuration https://github.com/wso2/samples-is/pull/405/files#diff-34fe1b8cbee00497c7574755a2a49dc01937e2a04b08a16c2e7d3cfd24822197L88. Also I have seen some of them set the sub org id there, but it is not required. Hence why we can't remove that unnecessary config in order to not to confuse or answer back from us why that config stands for

Yes, it was for backward compatibility, but we have previous b2b sample app releases which can be used for WSO2 PCC (The backward compatibility aid will be needed until PCC backed by IS 6.1). With these facts, still do we need that config in our latest sample. Please share the recommendations.

sadilchamishka · 2023-03-11T16:43:06Z

b2b-sample/README.md

-    "ManagementAPIConfig": {
-      "SharedApplicationName": "Guardio-Business-App",
-      "UserStore" : "DEFAULT"


These configs are used by the admin app. Hence keeping these configs within business app can cause confusions. By moving that config to admin app config section will be helpful incase the config.json file was required to be managed as two separate files to configure for the maintainability.

sadilchamishka · 2023-03-11T16:44:12Z

b2b-sample/README.md

+    },
+    "ManagementAPIConfig": {
+      "SharedApplicationName": "Guardio-Business-App",
+      "UserStore" : "DEFAULT"


Moved the configs to an appropriate place as discussed in the comment

sadilchamishka · 2023-03-11T16:46:30Z

b2b-sample/README.md

-* If the federated organization id is returned in the idToken (in user_organization variable) when a user is logging
-* into an organization, remove the `CommonConfig.ApplicationConfig.SampleOrganization` section from the <i>config.json</i> file.


These settings may not required to be mentioned as normal users of the b2b sample app would be the users who try the b2b organization management feature of Asgardeo. For the users who try the b2b sample app with the PCC, we can suggest in the PCC documentation for the previously released b2b sample app.

I think it would be better if we have this part (with a change), mentioning that, in the PCC environment the developer needs to setup this to work with the sample application.

sadilchamishka · 2023-03-11T16:51:50Z

b2b-sample/README.md

+**_NOTE:_**  With the latest B2B organization management features provided by WSO2 Identity Server, the following operations are allowed in sub organization for the organization creator.
+
+1 - onboarding enterprise IDP.
+2 - Update authentication options of the shared applications.
+3 - Delete the business users.


With the latest features, above operations can be done from the Console app itself which exceeds the capabilities of the b2b sample app. In order to not to limit the functionalities which can be done at the sub organization by the less features of the b2b sample app, we can suggest to check the Console app.
ex - configure multiple authentication steps / options
- delete users

sadilchamishka · 2023-03-11T16:55:04Z

b2b-sample/README.md

@@ -159,22 +159,12 @@ setup the config json file as mentioned above.

 ### Step 6: Setup the identity provider for the Guardio-Business-App

-* For this we will create an external identity provider in Asgardeo. After creating an identity provider in Asgardeo.


external identity provider in Asgardeo -> external identity provider in sub organization

https://github.com/wso2/samples-is/pull/405/files#diff-34fe1b8cbee00497c7574755a2a49dc01937e2a04b08a16c2e7d3cfd24822197R162

sadilchamishka · 2023-03-11T16:58:09Z

b2b-sample/README.md

-### Step 7: Create a corporate user
-* You need to create a new corporate user to access the **Guardio-Business-App**.
-
-* To create a corporate user for Best Auto Mart organization go to the Asgardeo console where you set up the corporate IDP
-  and create a user named `John`.
-


Business user will be log in via the Enterprise IDP. Even after configuring the enterprise IDP, the basic authentication option will be removed. In such cases, there is no point of creating a business user in the sub organization itself.

sadilchamishka · 2023-03-11T16:58:31Z

b2b-sample/README.md

@@ -187,7 +177,7 @@ setup the config json file as mentioned above.
 > **_NOTE:_** If `nx serve business-app` produced an error, try with `npx nx serve business-app`

 * Open a **private browser** and type [http://localhost:3000](http://localhost:3000) with your browser to see the result.
-* Login from the created user `John` to the application.
+* Login via the configured enterprise IDP to the application.


Related to https://github.com/wso2/samples-is/pull/405/files#r1133120185

sadilchamishka · 2023-03-11T17:00:04Z

b2b-sample/apps/business-admin-app/pages/api/settings/user/viewUsers.ts

@@ -40,7 +40,7 @@ export default async function viewUsers(req: NextApiRequest, res: NextApiRespons

    try {
        const fetchData = await fetch(
-            `${getOrgUrl(orgId)}/scim2/Users`,
+            `${getOrgUrl(orgId)}/scim2/Users?count=100`,


Fix for users not listing the sample app. Without a count, the SCIM user list API response will be in below format.

{ "totalResults": 1, "startIndex": 1, "itemsPerPage": 0, "schemas": [ "urn:ietf:params:scim:api:messages:2.0:ListResponse" ] }

Shall we add domain=<userstore> attribute if there is a defined userstore here https://github.com/wso2/samples-is/pull/405/files#diff-34fe1b8cbee00497c7574755a2a49dc01937e2a04b08a16c2e7d3cfd24822197R130

Adding count is not necessary right. IMO, looks like the SCIM api is broken

Need to fix the SCIM API. Also need to add the #405 (comment) improvement

sadilchamishka · 2023-03-11T17:01:48Z

...s/data-access-controller/src/lib/controller/controllerSwitchOrg/controllerDecodeSwitchOrg.ts

+        } else if (token.user.org_id) {
+
+            return token.user.org_id;


Fix for the B2C user login issue. In B2C login cases, the user_organization claim won't be in the id token. The org_id claim of the token will represent the user_organization in such cases.

AnuradhaSK · 2023-03-12T17:52:41Z

b2b-sample/README.md

@@ -47,6 +47,8 @@ Now we need **two** applications to communicate with the **Guardio-Business-App*

 Create two applications named **Guardio-Business-App** and **Guardio-Admin-App** [This should be a management application].

+Share both applications with all the organizations by clicking the share button.
+


Why Guardio-Business-App needs a client credential grant?
I think it should be changed to Organization Switch and Code

Yes, We can skip client credential grant
Fixed by - 221eee7

Achintha444

Shall we also have the current version released as a version, before merging this PR ?

ShanChathusanda93 · 2023-04-06T05:09:50Z

...s/data-access-controller/src/lib/controller/controllerSwitchOrg/controllerDecodeSwitchOrg.ts

-        } else if (config.CommonConfig.ApplicationConfig.SampleOrganization[0]) {
-
-            return config.CommonConfig.ApplicationConfig.SampleOrganization[0].id;
-        } else {
-


Shall we change the order of the config check rather removing them?

Sure, based on the conclusion of this discussion https://github.com/wso2/samples-is/pull/405/files#r1133118204, will attend to this

sadilchamishka · 2023-04-25T07:24:20Z

Some of the fixes were already addressed in separate PRs.

B2B sample app improvements

910475b

sadilchamishka commented Mar 11, 2023

View reviewed changes

additional changes

d12ef29

AnuradhaSK reviewed Mar 12, 2023

View reviewed changes

Remove client credential grant which is not required

221eee7

Achintha444 reviewed Mar 24, 2023

View reviewed changes

ShanChathusanda93 reviewed Apr 6, 2023

View reviewed changes

sadilchamishka closed this Apr 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

B2B sample app improvements #405

B2B sample app improvements #405

sadilchamishka commented Mar 11, 2023

sadilchamishka Mar 11, 2023

sadilchamishka Mar 11, 2023

sadilchamishka Mar 11, 2023 •

edited

Loading

sadilchamishka Mar 11, 2023

sadilchamishka Mar 13, 2023

ShanChathusanda93 Apr 6, 2023

sadilchamishka Apr 6, 2023

sadilchamishka Apr 6, 2023 •

edited

Loading

sadilchamishka Mar 11, 2023

sadilchamishka Mar 11, 2023

sadilchamishka Mar 11, 2023

Achintha444 Mar 24, 2023

sadilchamishka Mar 11, 2023

sadilchamishka Mar 11, 2023

sadilchamishka Mar 11, 2023

sadilchamishka Mar 11, 2023

sadilchamishka Mar 11, 2023 •

edited

Loading

AnuradhaSK Mar 23, 2023

malithie Mar 23, 2023

AnuradhaSK Mar 24, 2023

sadilchamishka Mar 11, 2023

AnuradhaSK Mar 12, 2023

sadilchamishka Mar 13, 2023

Achintha444 left a comment

ShanChathusanda93 Apr 6, 2023

sadilchamishka Apr 6, 2023

sadilchamishka commented Apr 25, 2023

		@@ -47,6 +47,8 @@ Now we need two applications to communicate with the *Guardio-Business-App

		Create two applications named Guardio-Business-App and Guardio-Admin-App [This should be a management application].

		Share both applications with all the organizations by clicking the share button.

		* Also, On the User Attributes tab, click on + Add User Attributes.
		* Select `Email`, `First Name`, `Last Name`, and `Username` from the list of attributes.

		* If the federated organization id is returned in the idToken (in user_organization variable) when a user is logging
		* into an organization, remove the `CommonConfig.ApplicationConfig.SampleOrganization` section from the <i>config.json</i> file.

		@@ -159,22 +159,12 @@ setup the config json file as mentioned above.

		### Step 6: Setup the identity provider for the Guardio-Business-App

		* For this we will create an external identity provider in Asgardeo. After creating an identity provider in Asgardeo.

B2B sample app improvements #405

B2B sample app improvements #405

Conversation

sadilchamishka commented Mar 11, 2023

Purpose

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sadilchamishka Mar 11, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sadilchamishka Apr 6, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sadilchamishka Mar 11, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Achintha444 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sadilchamishka commented Apr 25, 2023

sadilchamishka Mar 11, 2023 •

edited

Loading

sadilchamishka Apr 6, 2023 •

edited

Loading

sadilchamishka Mar 11, 2023 •

edited

Loading