Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add security codes migration service from old soap service to compatible with new Rest service. #53

Merged
merged 3 commits into from
Aug 4, 2018
Merged

Add security codes migration service from old soap service to compatible with new Rest service. #53

merged 3 commits into from
Aug 4, 2018

Conversation

GDRDABARERA
Copy link
Contributor

@GDRDABARERA GDRDABARERA commented Jul 30, 2018 •
edited
Loading

Purpose

If a customer used old SOAP service to generate security codes if they migrate to our new REST Service they can't use old security codes. This client will migrate these old security codes to compatible with new REST service.

Resolved #65

denuwanthi
denuwanthi reviewed Jul 30, 2018
View reviewed changes
...2/carbon/identity/securitycode/migration/internal/IdentityCodeMigrationServiceComponent.java Outdated

SecurityCodeMigrationService securityCodeMigrationService = new SecurityCodeMigrationService();
String migrateCode = System.getProperty(SYSTEM_PROPERTY_MIGRATE);
String tenantToMigrate = System.getProperty(SYSTEM_PROPERTY_TENANTS);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible improvement to consider:
Provide system property for a tenant range.
When there are around 3000+ tenants it becomes difficult to test migrations as it will take some time.If we can provide a property for set of tenant range, they can migrate chunk wise.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added below

@GDRDABARERA GDRDABARERA mentioned this pull request Jul 30, 2018
Closed
@nilasini nilasini merged commit 38c5f76 into wso2:master Aug 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denuwanthi denuwanthi denuwanthi approved these changes

@nilasini nilasini nilasini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GDRDABARERA @denuwanthi @nilasini