Fix issues in QSG and GDPR-QSG to support IS 5.7.0 API changes #79
Conversation
| echo "| Before run this make sure your WSO2 IS and Tomcat is running |" | ||
| echo "| in default ports WSO2 IS - localhost:9443 |" | ||
| echo "| tomcat - localhost:8080 |" | ||
| echo "| Next, Try the below steps in order |" |
There was a problem hiding this comment.
Shall we have above part edited as below?
echo "| Before running this, make sure your WSO2 IS and Tomcat is |"
echo "| running in default ports. |"
echo "| WSO2 IS - localhost:9443 |"
echo "| tomcat - localhost:8080 |"
echo "| Next, try below steps in order. |"
There was a problem hiding this comment.
This is releasing basically for IS 5.7.0, due to API changes in some admin services of IS 5.7.0, this QSG does not work for lower versions. We need to handle this issue in QSG level if not we can not compatible with all the version. Issue: #81. Let's fix this in the release
| @@ -122,7 +122,7 @@ | |||
| <li class="dropdown user-name"> | |||
| <a href="#" class="dropdown-toggle" data-toggle="dropdown"> | |||
| <img class="img-circle" height="30" width=30" src="img/Admin-icon.jpg"> <span | |||
There was a problem hiding this comment.
Seems like an error here with width=30"
| @@ -499,6 +498,14 @@ curl -s -k -H "Authorization: Basic ${auth}" -H "Content-Type: text/xml" -H "SOA | |||
| <xsd1:permissionAndRoleConfig></xsd1:permissionAndRoleConfig> | |||
| <!--Optional:--> | |||
| <xsd1:saasApp>false</xsd1:saasApp> | |||
| <xsd1:owner> | |||
There was a problem hiding this comment.
I was under the impression we were not going to use the default admin user in any of our demonstrations of the QSG
There was a problem hiding this comment.
Yes this should be Cameron
There was a problem hiding this comment.
This was initially created with the SPs registered in admin user. I fixed only the API changes. Will fix this in the next milestone release.
There was a problem hiding this comment.
An issue #80 created. This will be fixed this for the next release
| @@ -24,7 +24,7 @@ | |||
| <!--Optional:--> | |||
| <xsd1:applicationName>notification-center</xsd1:applicationName> | |||
| <!--Optional:--> | |||
| <xsd1:callbackUrl>http://localhost.com:8080/notification/oauth2client</xsd1:callbackUrl> | |||
| <xsd1:callbackUrl>http://localhost:8080/notification/oauth2client</xsd1:callbackUrl> | |||
There was a problem hiding this comment.
can't we configure the hotstname as a variable here? e.g. http://${host.name}:8080/notification/oauth2client and then read the actual hostname from a single file as it is hardcoded in several places?
There was a problem hiding this comment.
This will be fixed in next milestone #82
Purpose