This repository has been archived by the owner on Dec 24, 2023. It is now read-only.
Optimize get page scrollheight #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in some cases the default `document.body.scrollHeight` is not sufficient, the can be other factors that influence determining the height of the page - for full page screenshots the scollbars only need to be hidden after a scroll, bot before. This might block scrolling in some situations
in some cases the scoll can't be done on the window, it need to be done on the largest element.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
document.body.scrollHeightis not sufficient, there can be other factors that influence determining the height of the pageoverflowto thebodyinstead of thehtmlelement