Skip to content
This repository has been archived by the owner on Dec 24, 2023. It is now read-only.

Optimize get page scrollheight #18

Merged
merged 7 commits into from
May 26, 2019
Merged

Optimize get page scrollheight #18

merged 7 commits into from
May 26, 2019

Commits on May 24, 2019

  1. feat: initial implementation for the new page scroll height 

    - in some cases the default `document.body.scrollHeight` is not sufficient, the can be other factors that influence determining the height of the page
- for full page screenshots the scollbars only need to be hidden after a scroll, bot before. This might block scrolling in some situations
    @wswebcreation
    wswebcreation committed May 24, 2019
    Configuration menu
    Copy the full SHA
    dc24e10 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2019

  1. feat: update the scrollToPosition 

    in some cases the scoll can't be done on the window, it need to be done on the largest element.
    @wswebcreation
    wswebcreation committed May 25, 2019
    Configuration menu
    Copy the full SHA
    18d9dd1 View commit details
    Browse the repository at this point in the history

  2. test: add unit tests

    @wswebcreation
    wswebcreation committed May 25, 2019
    Configuration menu
    Copy the full SHA
    ede4e3d View commit details
    Browse the repository at this point in the history

  3. chore: remove not needed call

    @wswebcreation
    wswebcreation committed May 25, 2019
    Configuration menu
    Copy the full SHA
    1237179 View commit details
    Browse the repository at this point in the history

  4. test: increase coverage on screenshots

    @wswebcreation
    wswebcreation committed May 25, 2019
    Configuration menu
    Copy the full SHA
    9dbe93b View commit details
    Browse the repository at this point in the history

Commits on May 26, 2019

  1. fix: add overflow to body instead of html

    @wswebcreation
    wswebcreation committed May 26, 2019
    Configuration menu
    Copy the full SHA
    5991a88 View commit details
    Browse the repository at this point in the history

  2. chore: update dependencies

    @wswebcreation
    wswebcreation committed May 26, 2019
    Configuration menu
    Copy the full SHA
    1696fc8 View commit details
    Browse the repository at this point in the history