-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more rsvp command aliases #67
Conversation
This builds off the tireless work of @jjst by adding new command aliases for `rsvp yes`: - `:+1:` is the short form of `:thumbs_up:` (because who has time to write `:thumbs_up:`?) - `y` is just short for `yes` (because who has time to write `yes`?)
Hi @munyari . Thanks for your contribution! Cna you make sure all tests pass? Thanks! |
LOL oops!! This is where I confess I don't have all the build stuff setup yet because I'm having pip issues. Looks like a regex escaping thing though, maybe just fixing that will do it |
Yeah, that fixed it. I'll get all my stuff properly set up next time 😄 |
Awesome. Was not aware that |
I don't think Zulip has |
Ah! I tested in a PM and it works, but doesn't autocomplete. Weird! Maybe a bug in Zulip? |
Now to be fair, replying with "rsvp 👎" seems a little bit negative and I don't think anyone ever used it 😛 |
Gotta love zulip! I agree though, a thumbs down may be too negative. On the other hand, if we already support |
👍 it'll get done @kokeshii |
This builds off the tireless work of @jjst by adding new command aliases
for
rsvp yes
::+1:
is the short form of:thumbs_up:
(because who has time towrite
:thumbs_up:
?)y
is just short foryes
(because who has time to writeyes
?)n
is just short forno
(because who has time to writeno
?)This PR also addresses #65