Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more rsvp command aliases #67

Merged
merged 5 commits into from
Aug 2, 2016
Merged

Add more rsvp command aliases #67

merged 5 commits into from
Aug 2, 2016

Conversation

munyari
Copy link
Contributor

@munyari munyari commented Aug 2, 2016

This builds off the tireless work of @jjst by adding new command aliases
for rsvp yes:

  • :+1: is the short form of :thumbs_up: (because who has time to
    write :thumbs_up:?)
  • y is just short for yes (because who has time to write yes?)
  • n is just short for no (because who has time to write no?)

This PR also addresses #65

This builds off the tireless work of @jjst by adding new command aliases
for `rsvp yes`:

- `:+1:` is the short form of `:thumbs_up:` (because who has time to
  write `:thumbs_up:`?)
- `y` is just  short for `yes` (because who has time to write `yes`?)
@wtfcarlos
Copy link
Owner

Hi @munyari . Thanks for your contribution!

Cna you make sure all tests pass? Thanks!

@munyari
Copy link
Contributor Author

munyari commented Aug 2, 2016

LOL oops!! This is where I confess I don't have all the build stuff setup yet because I'm having pip issues. Looks like a regex escaping thing though, maybe just fixing that will do it

@munyari
Copy link
Contributor Author

munyari commented Aug 2, 2016

Yeah, that fixed it. I'll get all my stuff properly set up next time 😄

@jjst
Copy link
Contributor

jjst commented Aug 2, 2016

Awesome. Was not aware that :+1: was a thing! Should we support :-1: as well then? (looks like it's a valid alias)

@munyari
Copy link
Contributor Author

munyari commented Aug 2, 2016

I don't think Zulip has :-1: funnily enough... At least it doesn't pop up automatically

@jjst
Copy link
Contributor

jjst commented Aug 2, 2016

Ah! I tested in a PM and it works, but doesn't autocomplete. Weird! Maybe a bug in Zulip?

@jjst
Copy link
Contributor

jjst commented Aug 2, 2016

Now to be fair, replying with "rsvp 👎" seems a little bit negative and I don't think anyone ever used it 😛

@munyari
Copy link
Contributor Author

munyari commented Aug 2, 2016

Gotta love zulip! I agree though, a thumbs down may be too negative. On the other hand, if we already support :thumbs_down:, then it makes sense to support :-1: too

@wtfcarlos
Copy link
Owner

@munyari @jjst Negative or not, we need symmetry in the implementation.

@munyari
Copy link
Contributor Author

munyari commented Aug 2, 2016

👍 it'll get done @kokeshii

@wtfcarlos wtfcarlos merged commit 005d8ef into wtfcarlos:dev Aug 2, 2016
@munyari munyari deleted the plus_one branch August 2, 2016 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants