You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently MarkupSafe is listed as install_requires, which is incorrect, it should be a pure requires since the package doesn't work without it. install_requires denotes packages which are only necessary to install the package, but if e.g. someone were to build a wheel for WTForms, then these requirements could be dropped from the resulting wheel.
It didn't matter until now since you don't publish wheels for WTForms on PyPI, but it's annoying when it's used with third party tools that would first install the package and then export it into a clean environment, since you will need to explicitly add the MarkupSafe requirement.
This came up when trying to create stubs for WTForms in typeshed, since their metadata parsing ignores install_requires, since those requirements only should come into play when the original package has to be installed into the environment.
The text was updated successfully, but these errors were encountered:
Currently
MarkupSafe
is listed asinstall_requires
, which is incorrect, it should be a purerequires
since the package doesn't work without it.install_requires
denotes packages which are only necessary to install the package, but if e.g. someone were to build a wheel forWTForms
, then these requirements could be dropped from the resulting wheel.It didn't matter until now since you don't publish wheels for
WTForms
on PyPI, but it's annoying when it's used with third party tools that would first install the package and then export it into a clean environment, since you will need to explicitly add theMarkupSafe
requirement.This came up when trying to create stubs for WTForms in typeshed, since their metadata parsing ignores
install_requires
, since those requirements only should come into play when the original package has to be installed into the environment.The text was updated successfully, but these errors were encountered: