Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package metadata is incorrect #802

Closed
Daverball opened this issue Aug 9, 2023 · 1 comment
Closed

Package metadata is incorrect #802

Daverball opened this issue Aug 9, 2023 · 1 comment

Comments

@Daverball
Copy link

Daverball commented Aug 9, 2023

Currently MarkupSafe is listed as install_requires, which is incorrect, it should be a pure requires since the package doesn't work without it. install_requires denotes packages which are only necessary to install the package, but if e.g. someone were to build a wheel for WTForms, then these requirements could be dropped from the resulting wheel.

It didn't matter until now since you don't publish wheels for WTForms on PyPI, but it's annoying when it's used with third party tools that would first install the package and then export it into a clean environment, since you will need to explicitly add the MarkupSafe requirement.

This came up when trying to create stubs for WTForms in typeshed, since their metadata parsing ignores install_requires, since those requirements only should come into play when the original package has to be installed into the environment.

@Daverball
Copy link
Author

Alright the issue was something else I think. I might reopen if it's actually an issue.

@Daverball Daverball closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant