Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

werkzeug sphinx theme #567

Merged
merged 9 commits into from Apr 21, 2020
Merged

werkzeug sphinx theme #567

merged 9 commits into from Apr 21, 2020

Conversation

azmeuk
Copy link
Member

@azmeuk azmeuk commented Apr 18, 2020

Use the werkzeug sphinx theme, and a sphinx configuration similar to the one werkzeug is using.

Screenshot_2020-04-19 Fields — WTForms Documentation (3 0 x)

Fixes #560

@azmeuk azmeuk added the documentation Related to the documentation label Apr 20, 2020
@davidism
Copy link
Member

Can you add docs/requirements.txt and .readthedocs.yaml too? See https://github.com/pallets/click/blob/master/.readthedocs.yaml for example. Right now the builds are failing because RTD doesn't know to install sphinx-issues or pallets-sphinx-themes.

@azmeuk azmeuk force-pushed the issue-560-sphinx-theme branch 2 times, most recently from fc60f1c to 1002d54 Compare April 20, 2020 15:46
@azmeuk
Copy link
Member Author

azmeuk commented Apr 20, 2020

Done.

@davidism davidism self-requested a review April 21, 2020 18:28
@davidism davidism changed the base branch from master to 2.2-maintenance April 21, 2020 20:49
@davidism
Copy link
Member

davidism commented Apr 21, 2020 •
edited

Did a bunch more cleanup, added a RTD config, rebased to 2.x branch.

@davidism davidism merged commit 2828463 into wtforms:2.2-maintenance Apr 21, 2020
@azmeuk azmeuk deleted the issue-560-sphinx-theme branch April 22, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidism davidism davidism approved these changes

Assignees
No one assigned
Labels
documentation Related to the documentation
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the documentation theme
2 participants
@azmeuk @davidism