Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module feature (Feed Reader): Add a label to display, and perhaps also group by it #1138

Closed
poetaman opened this issue Oct 22, 2021 · 2 comments · Fixed by #1171
Closed

Module feature (Feed Reader): Add a label to display, and perhaps also group by it #1138

poetaman opened this issue Oct 22, 2021 · 2 comments · Fixed by #1171
Labels
💥 feature "Good luck, you're gonna need it."

Comments

@poetaman
Copy link

poetaman commented Oct 22, 2021 •
edited
Loading

What should it do?

The feeds of the feedreader are probably randomized. It would be nice to see which feed is coming from which RSS feed source by seeing a label associated with that source. Example...

Setting:

      feeds:
        - https://www.reddit.com/r/linux/.rss
        - https://www.reddit.com/r/neovim/.rss
        - https://www.reddit.com/r/vim/.rss
        - https://www.reddit.com/r/zsh/.rss
        - https://www.reddit.com/r/bash/.rss

returns something like this:

 1. [MATE+ Compiz] this graphical glitch is happening on m
 2. Quick tip for anyone having CPU spikes with EFM       
 3. Any idea what might be causing my Terminal to look lik
 4. Python Script Workaround to Be Able to Use Virtual Bac
 5. nvim-lsp-typescript-config                            
 6. Suggest some plugins and user experience              
 7. Lualine now has a new home                            
 8. lspsaga best fork?                                    
 9. clear fzf.vim unexcepted highlight column             
10. i need a vimscript wizard again                       
11. Clementine vs Strawberry media players                
12. How To Access A Particular Field In An Index In An Arr
13. Nvim lsp javascript formating on save issue with open 
14. PSA: vim.diagnostics api has changed a little bit on m
15. MX Linux 21 has been released                         
16. onedarkpro.nvim - cause the community needs more oneda
17. How do I get sed to remove a string that contains cont
18. Autosaving manual folds not working                   
19. How Much Control will Users have over Scheduling on Al
20. Is there a way to stay in command mode after pressing

This ticket is asking for user to be able to specify a label for each feed source, and append it in front of the feed OR with an option grouped group the feeds belonging to each rss feed label and present them together. For grouped mode, ideally color the label with a different color to make it stand out from the rest of titles of feeds under it.

Benefit: It would make it simple for user to look at the ares of their interest at any given point in time and jump accordingly. At present looking at the random feed requires scanning all the lines to find the ones belonging to present topic of interest.
@senorprogrammer senorprogrammer added the 💥 feature "Good luck, you're gonna need it." label Oct 28, 2021
@senorprogrammer
Copy link
Collaborator

Agreed, that would be cool.

igbanam added a commit to igbanam/wtf that referenced this issue Jan 13, 2022
@igbanam
Tag Stories in FeedReader
a399859 
With the FeedReader, it's possible to have multiple feeds. With multiple feeds, all stories are jumbled up in the same
list. One cannot know the source of a story at first glance. The way this possible is the to use the `t` keyboard
shortcut which cycles the showType through title, link, and content. It is better UX to have some tag showing the origin
of a story.

This change introduces a tag on the story title. This tag is the same as the Feed.Title. This change is backward
compatible. If a feed does not come with a title, this change yields itself to the previous implementation.

Fixes wtfutil#1138
@igbanam igbanam mentioned this issue Jan 13, 2022
Merged
@igbanam
Copy link
Contributor

igbanam commented Jan 13, 2022

So I saw this and thought to take a stab at this. Please review the above and let me know if there is any better way I should be writing Go.

p.s: This is the first time I looked into Go ever. So I am winging it on half a wing here. Looking to learn from y'all on Go best practices.

senorprogrammer pushed a commit that referenced this issue Jan 14, 2022
@igbanam
Tag Stories in FeedReader (#1171)
09f9820 
* Tag Stories in FeedReader

With the FeedReader, it's possible to have multiple feeds. With multiple feeds, all stories are jumbled up in the same
list. One cannot know the source of a story at first glance. The way this possible is the to use the `t` keyboard
shortcut which cycles the showType through title, link, and content. It is better UX to have some tag showing the origin
of a story.

This change introduces a tag on the story title. This tag is the same as the Feed.Title. This change is backward
compatible. If a feed does not come with a title, this change yields itself to the previous implementation.

Fixes #1138

* Format with gofmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💥 feature "Good luck, you're gonna need it."
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tag Stories in FeedReader igbanam/wtf
3 participants
@senorprogrammer @igbanam @poetaman