Tag Stories in FeedReader #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the FeedReader, it's possible to have multiple feeds. With multiple feeds, all stories are jumbled up in the same list. One cannot know the source of a story at first glance. The way this possible is the to use the `t` keyboard shortcut which cycles the showType through title, link, and content. It is better UX to have some tag showing the origin of a story. This change introduces a tag on the story title. This tag is the same as the Feed.Title. This change is backward compatible. If a feed does not come with a title, this change yields itself to the previous implementation. Fixes wtfutil#1138
|
Before…
After…
|
|
I think your linter issues can be resolved by running
|
|
This looks good to me. If you like, I can fix that linting issue and merge it in, or you can fix it. Let me know either way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the FeedReader, it's possible to have multiple feeds. With multiple feeds, all stories are jumbled up in the same list. One cannot know the source of a story at first glance. The way this possible is the to use the
tkeyboard shortcut which cycles the showType through title, link, and content. It is better UX to have some tag showing the origin of a story.This change introduces a tag on the story title. This tag is the same as the Feed.Title. This change is backward compatible. If a feed does not come with a title, this change yields itself to the previous implementation.
To test this, run tool with
make run. Feeds which have titles in their schemas should show up with their titles in square brackets. Examples of such feeds I have in my config are Hacker News, Ruby Weekly, and avdi.codesFixes #1138