Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No guava dependencies #197

Merged
merged 7 commits into from Jun 29, 2020
Merged

No guava dependencies #197

merged 7 commits into from Jun 29, 2020

Conversation

pun-ky
Copy link

@pun-ky pun-ky commented May 26, 2020

This is an attempt for eliminating Guava related runtime errors like in #190

Improved 2 things:

  • removed direct dependency to guava 28-jre which is the even higher version than the most recent version of sonar-java-plugin -26-jre
  • removed all Guava usages from code, no imports to classes com.google.*

Regardless Guava version provided by Sonar, our plugin should work fine.

@@ -293,8 +294,8 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>3.5.1</version>
<configuration>
<source>1.8</source>
<target>1.8</target>
<source>11</source>
Copy link
Author

@pun-ky pun-ky May 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as of we are mentioning that most recent version of our plugin requires Java 11, to be able to write code in Java 11 I decided to update it also

@jplucinski jplucinski self-requested a review May 26, 2020 12:21
@toniedzwiedz
Copy link
Collaborator

@pun-ky I've got #196 to build. Once those changes are merged to master and re-integrated into this branch, the build should pass just fine.

@coveralls
Copy link

coveralls commented Jun 19, 2020

Coverage Status

Coverage decreased (-0.5%) to 95.574% when pulling 449927a on no-guava into a4e6d6c on master.

@pun-ky pun-ky requested a review from toniedzwiedz June 25, 2020 10:43
@sonarcloud
Copy link

sonarcloud bot commented Jun 25, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 4 Code Smells

96.0% 96.0% Coverage
0.0% 0.0% Duplication

@toniedzwiedz toniedzwiedz merged commit c73220d into master Jun 29, 2020
@toniedzwiedz
Copy link
Collaborator

Tested the new version with Docker images of SonarQube 7.9.3 and 8.3.0. The exceptions mentioned in #198 and #190 no longer occur. SonarQube starts up successfully.

@toniedzwiedz
Copy link
Collaborator

Should also take care of #199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants