Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to override jdk download URL template #70

Closed
krystian-panek-vmltech opened this issue Feb 16, 2023 · 2 comments
Closed

Allow to override jdk download URL template #70

krystian-panek-vmltech opened this issue Feb 16, 2023 · 2 comments
Labels
improvement Improvement to an existing feature

Comments

@krystian-panek-vmltech
Copy link
Contributor

When download URL is not specified then jdk is downloaded from url determined dynamically. However when jdk maintainer will change again then the download URL hard-coded will be no longer valid and there will be no option to override default behavior

How about download_url_template config param with adoptium explicitly (no longer implicitly) defined there?
@krystian-panek-vmltech krystian-panek-vmltech added the improvement Improvement to an existing feature label Feb 16, 2023
@krystian-panek-vmltech
Copy link
Contributor Author

To make it customizable provide replace map as in go releaser to support differences in arch naming e.g amd64 vs x86_64

@krystian-panek-vmltech
Copy link
Contributor Author

fixed in 1.0.20 via config java.download.[url|replacements]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@krystian-panek-vmltech