Note tooltip new #229
Note tooltip new #229
Conversation
Conflicts (resolved): CHANGELOG.md report/src/main/webapp/assets/css/main.css
| @@ -235,6 +235,6 @@ | |||
| display: inline-block; | |||
| } | |||
|
|
|||
| .preformatted { | |||
| font-family: monospace; | |||
There was a problem hiding this comment.
Is this a desired change?
I think that it can cause some regression resulting in few visual glitches. For example here:
There was a problem hiding this comment.
This class is back in css now.
| @@ -39,6 +39,18 @@ | |||
| } | |||
| } | |||
|
|
|||
| &-footer_flex { | |||
| & { | |||
There was a problem hiding this comment.
Is this '&' necessary?
| @@ -39,6 +39,18 @@ | |||
| } | |||
| } | |||
|
|
|||
| &-footer_flex { | |||
There was a problem hiding this comment.
Maybe we could move those styles to &-footer and inside it just write '&_flex' ?
| } | ||
|
|
||
| button + button { | ||
| margin-right: 0px; |
There was a problem hiding this comment.
There is similar styling above in &-footer. Should these buttons have different styling based on whether they're in footer or footer_flex class?
There was a problem hiding this comment.
I tried to add modal-footer_flex class to all popups, but there is one in report.html, which I couldn't get on the site. I left the styling (button + button) until someone can tell when this popup occurs.
| @@ -235,6 +235,6 @@ | |||
| display: inline-block; | |||
| } | |||
|
|
|||
| .preformatted { | |||
| font-family: monospace; | |||
| .popover-content > p { | |||
There was a problem hiding this comment.
It's toolbar file and this style is pretty global, maybe it should be moved to main.scss?
Description
Removed empty space on popover when there is no comment.
Provided different logic and icons for comment and when there is no comment.
Introduced Font Awesome.
Improved buttons UX in editing comments.
I hereby agree to the terms of the AET Contributor License Agreement.