Hybi-16 #1
Merged
Hybi-16 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The protocol changes don't really affect the rest of the code we never check Sec-WebSocket-Version in the hybi-8 flow.
wulczer
added a commit
that referenced
this pull request
Oct 19, 2011
Support protocol version 13 (not any different from 8, as far as we're concerned).
|
I skimmed through thte diff between protocol version 8 and 13 and it seems that indeed it doesn't affest txWebSocket's code. As for the Sec-WebSocket-Origin header, I guess a helper method could be useful, but for now I'd let handling it to the users of the library (ie. not bother adding any helpers). Thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome 16 just released with the protocol version 16. The protocol changes don't really affect the rest of the code we never check Sec-WebSocket-Origin in the hybi-8 flow (as far as I could tell).
It /may/ affect some client code that manually checks the header "Sec-WebSocket-Origin", so maybe it could be interesting to provide a @Property or something that fetches the right Origin header based on the handshake version.