Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ASAR when building #103

Closed
sindresorhus opened this issue Dec 10, 2016 · 3 comments
Closed

Enable ASAR when building #103

sindresorhus opened this issue Dec 10, 2016 · 3 comments

Comments

@sindresorhus
Copy link
Member

sindresorhus commented Dec 10, 2016

Right now, Kap, is not built with ASAR. ASAR can considerably improve the startup time of the app by putting all JS files into one file. @matheuss disabled it initally as it caused some problems with Aperture.js. ASAR should in theory handle child processes, but if we can't work it out, we can use the electron-builder asarUnpack option.

This should happen after Kap 1.0.


Alternatively, we could switch from execa (it uses .spawn underneath) to .execFile: http://electron.atom.io/docs/tutorial/application-packaging/#executing-binaries-inside-asar-archive

@sindresorhus
Copy link
Member Author

sindresorhus commented May 14, 2017

I look into this today and opened an Electron issue about it: electron/electron#9459

We also need to set this in the "build" config of package.json:

"asarUnpack": [
   "vendor/ffmpeg"
]

Unless electron-builder can detect it somehow. I'll test when it's fixed in Electron.

@sindresorhus sindresorhus self-assigned this May 14, 2017
@onordbo onordbo moved this from Icebox to Backlog in 2.0.0 Oct 19, 2017
@albinekb
Copy link
Collaborator

albinekb commented Oct 24, 2017

@sindresorhus should we just enable asar and asarUnpack the aperture (and ffmpeg) binary? Wouldn't that work 🤔

@sindresorhus
Copy link
Member Author

@albinekb I've tried before but got stuck on a problem. Maybe you could give it a try too?

Here's a start: bb5749e

screen shot 2017-10-27 at 16 19 29

I can't seem to find the Aperture binary.

@skllcrn skllcrn moved this from Backlog to 2.0 Beta in 2.0.0 Oct 30, 2017
@skllcrn skllcrn moved this from 2.0 Beta to In progress in 2.0.0 Oct 31, 2017
sindresorhus added a commit to wulkano/Aperture that referenced this issue Nov 8, 2017
@skllcrn skllcrn moved this from In progress to Production ready in 2.0.0 Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
2.0.0
  
Production ready
Development

No branches or pull requests

5 participants