Fix macOS 12 compatibility #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4cm4k1
force-pushed
the
macos-12-monterey-fix
branch
from
0ee0fc1
to
07c2170
Compare
4cm4k1
changed the title
macos-release, which adds macOS Monterey; fixes #1019 #1025macos-release; fixes #1019 and #1025
sindresorhus
changed the title
macos-release; fixes #1019 and #1025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades
macos-releaseto the latest minor version, which adds macOS Monterey's version info, as suggested by @dabing1022 here.Locally on macOS 12.0 Beta (21A5304g), I have run
yarn test(all 26 pass) and verified that this fixes #1019 and fixes #1025 by runningyarn distand testing the built app myself.