Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Preferences and add tab support #643

Merged
merged 8 commits into from
Mar 10, 2019
Merged

Conversation

karaggeorge
Copy link
Member

@karaggeorge karaggeorge commented Mar 10, 2019

Updates the tab display on the Preferences window and adds tab support.

Also adds tab support to the plugin config window.

Screen Shot 2019-03-09 at 7 13 07 PM

Finally, it attempts to fix this bug. Haven't been able to reproduce in this branch's build yet. I think it had something to do with the Item components not being the same when the page was server-rendered and when it was being rendered on the app. I gave the components a key so hopefully that fixed it

image

@karaggeorge karaggeorge mentioned this pull request Mar 10, 2019
@sindresorhus
Copy link
Member

In Plugins => Discover, if I tab until the last plugin in the list, and then tab again, it seems to select something hidden. If I tab yet another time, it selects the "General" tab.

@sindresorhus
Copy link
Member

Otherwise, looks good.

@skllcrn
Copy link
Member

skllcrn commented Mar 10, 2019

This needs some design tweaks, but we can address that in #644.

@karaggeorge
Copy link
Member Author

@sindresorhus Yeah, that happens in all windows. I noticed it first when I was working on the cropper and it drove me crazy. The element that receives focus after the last one is the body of the page. It's a known thing in chrome/chromium apparently. I tried a bunch of things like setting tabIndex to -1 on it but nothing worked. So for all pages it takes one extra tab to go back to the start. Not sure if there's anything we can do about it at this point

@sindresorhus
Copy link
Member

@karaggeorge Ah ok. Can you open an issue so we can track it? Maybe some random person passing by have a good workaround. Would be good to include a link to the Chrome issue too.

@sindresorhus sindresorhus merged commit 474306c into master Mar 10, 2019
@sindresorhus sindresorhus deleted the cleanup-preferences branch March 10, 2019 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants