Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editor controls #683

Merged
merged 2 commits into from
Jul 6, 2019
Merged

Fix editor controls #683

merged 2 commits into from
Jul 6, 2019

Conversation

karaggeorge
Copy link
Member

Fixes #674 (again)

We fixed this in the past, but it sneaked in again as part of #587, which changed a lot of things around inputs

This PR also fixes a weird UI error that just started happening (but happened consistently) where if you recorded at a certain aspect ratio, the video preview in the editor would push the controls out of the window

@sindresorhus sindresorhus merged commit c8ec397 into master Jul 6, 2019
@sindresorhus sindresorhus deleted the fix-editor-controls branch July 6, 2019 06:14
karaggeorge added a commit that referenced this pull request Jul 7, 2019
karaggeorge added a commit that referenced this pull request Jul 8, 2019
* Add dark mode styles to the preferences window

* Add dark mode to exports window

* Add vibrancy to the editor

* Aadd dark mode support to the about window

* Add dark mode support to the config page

* Add dark mode support to the cropper

* Update yarn lock

* Small fixes and make kap-blue a bit lighter for dark mode

* Add dark mode version to the editor slider

* Fix color

* Editor style updates

* Preferences updates

* Style config window

* Give the cropper an initial size (#671)

* Fix editor controls (#683)

* Fix record button dark mode colors

* Fix advanced controls styles

* Enable scroll bar flag

* Fix settings colors

* Switch the link color in the about windows

* Fix config button color
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't type numbers beginning with 1 in export size box
2 participants