Fix audio related issues #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
requested changes
Sep 4, 2019
main/common/system-permissions.js
Outdated
| const getMicrophoneAccess = () => systemPreferences.getMediaAccessStatus('microphone'); | ||
|
|
||
| const promptSystemPreferences = async ({asked} = {}) => { | ||
| if (!asked) { |
There was a problem hiding this comment.
Suggested change
| if (!asked) { | |
| if (!hasAsked) { |
And I would do an early return.
|
@Geroimparable @kevincannon Can you test https://kap-artifacts.now.sh/fix-recording-with-sound and see if it fixes #693 for you? |
Co-Authored-By: Sindre Sorhus <sindresorhus@gmail.com>
|
Just tested this and it worked for me! 💪💪 |
sindresorhus
approved these changes
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #692
Fixes #693
Fixes #275
This also adds a lot of checks around having/granting access to the microphone, which might help reduce or troubleshoot problems people are having with recording sound
Also, the last beta was recording sound for me, so if someone can validate that this fixes #693 (using the build) that would be great