Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use electron-builder-notarize package #759

Merged
merged 4 commits into from Nov 23, 2019
Merged

Conversation

karaggeorge
Copy link
Member

No description provided.

@sindresorhus
Copy link
Member

I think you forgot to remove notarize.js.

@karaggeorge
Copy link
Member Author

Still testing it out. Haven't gotten it to work yet

@karaggeorge
Copy link
Member Author

Checked that this work, by turning on Signing on PRs. I have turned it off again, so it won't sign/notarize the commit here, but it should work in master. Notarized build from this PR is here

@sindresorhus sindresorhus merged commit ff3c828 into master Nov 23, 2019
@sindresorhus sindresorhus deleted the use-notarize-package branch November 23, 2019 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants