Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FPS option is a switch and not a dropdown #656

Closed
dotconnor opened this issue Apr 7, 2019 · 5 comments
Closed

FPS option is a switch and not a dropdown #656

dotconnor opened this issue Apr 7, 2019 · 5 comments

Comments

@dotconnor
Copy link
Contributor

macOS version: Mac OS X 10.14.5 18F96h
Kap version: 3.0.0-beta.5

Steps to reproduce

  • Open Kap
  • Navigate to Settings

Current behaviour

  • FPS option is switch

Expected behaviour

  • FPS option should be a dropdown OR be a switch and not toggle the native select on click

Workaround

Screen Shot 2019-04-06 at 11 13 38 PM

@karaggeorge
Copy link
Member

This issue is hopefully fixed in this: #643

Haven't done a beta release after that was merged, so we can keep this open and track if the issue persists in the next version

@skllcrn skllcrn moved this from To do to In progress in 3.0.0 Apr 8, 2019
@gotjoshua
Copy link

What is the current status on this?
I am curious about the planned implementation, and have the wish for something similar to Gifox:
RecordFPS+PlaybackFPS
It is great to be able to set the record FPS rather low and then the playback high to speed up the gif and shrink the size!

Should I open another issue to express/clarify this wish?

@gotjoshua
Copy link

Ok, I couldn't resist forking and poking around a bit when i realized KAP is react based!
(Very cool)
I managed to make a commit that changes to UI in the direction I am thinking (but I have no idea how to wire up those config options to the viewer and export options), could anyone point me in the right direction?

@skllcrn
Copy link
Member

skllcrn commented Jul 22, 2019

We're working on a new release and this issue should be fixed in the latest release @gotjoshua. We have 2 options for recording speed, as not all hardware deal well with recording at 60 FPS, and you can tweak the FPS as needed to manage the file size in the final export. It's generally a good idea to look for issues tagged "good first issue" or "help wanted" @gotjoshua, thank you for taking the time!

@skllcrn skllcrn closed this as completed Jul 22, 2019
3.0.0 automation moved this from In progress to Production ready Jul 22, 2019
@gotjoshua
Copy link

Hey, Thanks for the reply @skllcrn
I can see now that master has the pulldown menus instead of the switch - thats already great.

I am looking for more flexibility in the options...

As I said if i record a quick feature screenshot in 5fps and then export it at 15, I have a small file that plays at 3x speed and gets a point across very quickly.

As there is already a pulldown menu it was quite easy in the UI to add more options.
But I don't know how to wire up the new options to the actual app functionality.

I think this discussion does not belong here if it will continue, but I'm also not sure if a feature request is appropriate nor wished... what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
3.0.0
  
Production ready
Development

No branches or pull requests

4 participants