Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error handling in networking #31

Merged
merged 6 commits into from
Oct 23, 2020
Merged

Better error handling in networking #31

merged 6 commits into from
Oct 23, 2020

Conversation

kober32
Copy link
Member

@kober32 kober32 commented Oct 20, 2020 •
edited
Loading

This resolves #23 and resolves #24.

  • resolving SSL errors
  • resolving timeout errors
  • no longer trying to decode when the HTTP status code is different than 200

@kober32 kober32 mentioned this pull request Oct 20, 2020
Closed
petrdvorak
petrdvorak approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@petrdvorak petrdvorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@kober32 kober32 merged commit 6dd0efc into develop Oct 23, 2020
@kober32 kober32 deleted the 23-better-ssl-error-reporting branch October 23, 2020 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrdvorak petrdvorak petrdvorak approved these changes

@hvge hvge Awaiting requested review from hvge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better handling of http errors Better reporting of SSL errors
2 participants
@kober32 @petrdvorak