-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: merging response nodes #772
Merged
devsergiy
merged 15 commits into
master
from
sergiy/eng-4874-fix-merging-response-nodes-under-the-same-path-but-different
May 27, 2024
Merged
fix: merging response nodes #772
devsergiy
merged 15 commits into
master
from
sergiy/eng-4874-fix-merging-response-nodes-under-the-same-path-but-different
May 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
devsergiy
commented
Apr 16, 2024
•
edited
Loading
edited
- fix merging response nodes issue leading to "non-nullable field can't be null" errors
- fix duplicated fetches on complex abstract types queries
- add fetch input to trace for skipped fetches
devsergiy
force-pushed
the
sergiy/eng-4874-fix-merging-response-nodes-under-the-same-path-but-different
branch
2 times, most recently
from
May 26, 2024 06:01
922f897
to
c9cd9c3
Compare
make extract fetches configurable
fix resolvable variables equal check fix fetch configuration equal check
devsergiy
force-pushed
the
sergiy/eng-4874-fix-merging-response-nodes-under-the-same-path-but-different
branch
from
May 26, 2024 06:02
c9cd9c3
to
3c4e432
Compare
StarpTech
approved these changes
May 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
devsergiy
deleted the
sergiy/eng-4874-fix-merging-response-nodes-under-the-same-path-but-different
branch
May 27, 2024 16:56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.