Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(brew): update homebrew asset link to include v #1334

Merged

Conversation

marcneubauer
Copy link
Contributor

brew install wundergraph/wundergraph/wunderctl is broken, and returns the following error:

==> Fetching wundergraph/wundergraph/wunderctl
==> Downloading https://github.com/wundergraph/wundergraph/releases/download/0.176.2/wunderctl_0.176.2_Da
curl: (22) The requested URL returned error: 404

Error: wunderctl: Failed to download resource "wunderctl"
Download failed: https://github.com/wundergraph/wundergraph/releases/download/0.176.2/wunderctl_0.176.2_Darwin_arm64.tar.gz

This is because the string template for the URL to the asset in .github/goreleaser/.goreleaser-darwin.yml:127 is missing a 'v' after '/releases/downloads/' in the link.
Link from github releases:

https://github.com/wundergraph/wundergraph/releases/download/v0.176.2/wunderctl_0.176.2_Darwin_arm64.tar.gz
                                                           --^---

This closes issues:
wundergraph/homebrew-wundergraph#2
wundergraph/homebrew-wundergraph#3
Also related but closed- wundergraph/homebrew-wundergraph#1

Motivation and Context

Homebrew's so easy!

Marketing Changelog

Checklist

Copy link

vercel bot commented Nov 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
wundergraph-docs-v3 ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2023 0:02am

Copy link

vercel bot commented Nov 3, 2023

@marcneubauer is attempting to deploy a commit to the WunderGraph Team on Vercel.

A member of the Team first needs to authorize it.

@marcneubauer marcneubauer changed the title fix(brew): Update homebrew asset link to include v fix(brew): update homebrew asset link to include v Nov 3, 2023
@Pagebakers Pagebakers merged commit 3b95d05 into wundergraph:main Nov 6, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants