Upgrade local & Silta PHP to 7.4 & add PHPUnit testing setup. #122

tormi · 2020-09-01T14:50:23Z

This PR upgrades PHP to 7.4 and adds PHPUnit setup. Run lando phpunit --group admin_toolbar to test the PHPUnit setup.

This is the same PR as #121 with default PHP version upgraded to 7.4. See more at #121 (comment).

tormi · 2020-09-01T15:10:27Z

Should we upgrade PHP here as well: https://github.com/wunderio/drupal-project/blob/master/composer.json#L19 ?

tormi · 2020-09-07T08:23:00Z

Some related resources:

tormi · 2020-09-11T07:41:45Z

Ref: https://wunder.slack.com/archives/C012D7SA0N5/p1598970185002200

hkirsman · 2021-02-08T09:18:14Z

Please test mysql vs SQLite. Tested with this:

lando phpunit web/core/modules/block/tests/src/Functional/BlockCacheTest.php

Beware to get coffe as it might take few minutes in Mac!

With the current setup commited (using SQLite):

Test 1: Time: 01:57.210, Memory: 10.00 MB
Test2: Time: 01:53.786, Memory: 10.00 MB

Then in in my local changed the SIMPLETEST_DB parameter in .lando.yml to use the MySQL connection:

services:
  appserver:
    overrides:
      environment:
        SIMPLETEST_DB: "mysql://drupal9:drupal9@database/drupal9"

Test 1: Time: 00:41.787, Memory: 10.00 MB
Test2: Time: 00:42.491, Memory: 10.00 MB

That's more than 2x speed increase for me. Is it only my setup?

There is supposed to be also in memory support for SQLLite but didn't get it working.

 SIMPLETEST_DB: "sqlite://localhost/:memory:"

https://www.drupal.org/project/drupal/issues/2983452

In my previous tests with other projects didn't see any speed increase either. Then again I wasn't testing kernel tests.

…ser2-v0.1.

tormi · 2021-03-13T15:50:57Z

There are some failures with functional tests, cURL error 6: Could not resolve host: appserver_nginx:

➜  dp git:(feature/lando-phpunit-php-7.4) ✗ lando phpunit --group admin_toolbar
PHPUnit 9.5.2 by Sebastian Bergmann and contributors.

Testing 
EEEESSS                                                             7 / 7 (100%)

Time: 14:28.384, Memory: 927.00 MB

There were 4 errors:

1) Drupal\Tests\admin_toolbar\Functional\AdminToolbarAlterTest::testAdminToolbar
GuzzleHttp\Exception\ConnectException: cURL error 6: Could not resolve host: appserver_nginx (see https://curl.haxx.se/libcurl/c/libcurl-errors.html)

tormi · 2021-03-13T15:56:23Z

@hkirsman, thanks :) lando/lando#2283 (comment)

…MPLETEST_BASE_URL.

tormi · 2021-03-13T19:54:07Z

Should we run some tests in CircleCI as well?

…ser2-v0.1.

…MPLETEST_BASE_URL.

grumphp.yml

tormi · 2021-05-24T23:11:28Z

composer.json

@@ -30,6 +30,7 @@
    },
    "require-dev": {
        "drupal/core-dev": "^9.1",
+        "phpspec/prophecy-phpunit": "^2.0",


"phpspec/prophecy-phpunit" comes from https://www.drupal.org/node/3176567.

- Add minified phpunit_example module from https://www.drupal.org/project/examples. - Enable phpunit in grumphp.yml.

This reverts commit 528fdd2.

This tries to resolve the following error in CI: [ERROR] syntax error, unexpected '|', expecting variable (T_VARIABLE)

tormi · 2021-05-25T21:15:03Z

Looks like the problem with | (8658c52) is similar to https://stackoverflow.com/questions/66100477/symfony-5-2-3-interface-type-hinting

This reverts commit 8658c52.

tormi · 2021-05-26T17:32:22Z

Looks like CI is using PHP 7.3 instead of 7.4 and that could affect the output:

Command: '/home/circleci/project/vendor/bin/phpcs' '--extensions=php,inc,module,install,theme' '--parallel=20' '--runtime-set' 'testVersion' '7.3' '--standard=PHPCompatibility' '--basepath=.' '-s' 'web/modules/custom' 'web/sites'

Full verbose log:

circleci@e27c7346d55c:~/project$ vendor/bin/grumphp run -vvvv
Config file: /home/circleci/project/grumphp.yml
Working dir: /home/circleci/project
Project dir: /home/circleci/project
GIT working dir: /home/circleci/project
GIT repository dir: /home/circleci/project/.git
Bin dir: /home/circleci/project/vendor/bin
Composer file: /home/circleci/project/composer.json
[2021-05-26T17:28:48.943219+00:00] GrumPHP.DEBUG: Repository created (git dir: "/home/circleci/project/.git", working dir: "/home/circleci/project") [] []
[2021-05-26T17:28:48.943858+00:00] GrumPHP.INFO: run command: ls-files "/home/circleci/project"  [] []
[2021-05-26T17:28:48.947529+00:00] GrumPHP.DEBUG: last command (ls-files) duration: 3.60ms [] []
[2021-05-26T17:28:48.947604+00:00] GrumPHP.DEBUG: last command (ls-files) return code: 0 [] []
[2021-05-26T17:28:48.947648+00:00] GrumPHP.DEBUG: last command (ls-files) output: .circleci/config.yml .dockerignore .env.example .eslintignore .eslintrc.json .github/dependabot.yml .gitignore .lando.yml .lando/.env .lando/my_elasticsearch.yml .lando/php.ini .lando/phpunit.sh .lando/xdebug.sh .prettierrc.json .stylelintrc.json .vscode/extensions.json .vscode/launch.json .vscode/settings.json LICENSE README.md composer.json drush/Commands/PolicyCommands.php drush/README.md drush/drush.yml drush/sites/self.site.yml grumphp.yml load.environment.php package-lock.json package.json phpcs.xml phpunit.xml scripts/composer/ScriptHandler.php silta/nginx.Dockerfile silta/php.Dockerfile silta/shell.Dockerfile silta/silta-prod.yml silta/silta.yml web/.dockerignore web/modules/custom/phpunit_example/phpunit_example.info.yml web/modules/custom/phpunit_example/phpunit_example.module web/modules/custom/phpunit_example/src/AddClass.php web/modules/custom/phpunit_example/tests/src/Unit/AddClassTest.php web/sites/default/settings.php  [] []
GrumPHP is sniffing your code!

Running tasks with priority 0!
==============================

Running task 1/9: php_compatibility...
Running task 2/9: check_file_permissions...
Running task 3/9: php_check_syntax...
Running task 4/9: phpcs...
Running task 5/9: php_stan...
Running task 6/9: ecs...
Running task 7/9: yaml_lint...
Running task 8/9: json_lint...
Running task 9/9: phpunit...


Command: '/home/circleci/project/vendor/bin/phpcs' '--extensions=php,inc,module,install,theme' '--parallel=20' '--runtime-set' 'testVersion' '7.3' '--standard=PHPCompatibility' '--basepath=.' '-s' 'web/modules/custom' 'web/sites'

Command: '/home/circleci/project/vendor/bin/phpcs' '--standard=phpcs.xml' '--extensions=php,inc,module,install,theme' '--report=full' '--report-width=120' '--parallel=20' '--ignore=/vendor/,/node_modules/,/core/,/libraries/' '--basepath=.' '-s' 'web/modules/custom'

Command: '/usr/local/bin/php' '-l' 'web/modules/custom/phpunit_example/phpunit_example.module'

Command: '/usr/local/bin/php' '-l' 'web/modules/custom/phpunit_example/src/AddClass.php'

Command: '/home/circleci/project/vendor/bin/ecs' 'check' 'web/modules/custom' '--config=vendor/wunderio/code-quality/config/ecs.php' '--no-progress-bar' '--ansi' '--no-interaction'

Command: '/usr/local/bin/php' '-l' 'web/modules/custom/phpunit_example/tests/src/Unit/AddClassTest.php'

Command: '/usr/local/bin/php' '-l' 'web/sites/default/settings.php'

Command: '/usr/local/bin/php' '-l' 'web/sites/default/default.settings.php'

Command: '/usr/local/bin/php' '-l' 'web/sites/example.settings.local.php'

Command: '/usr/local/bin/php' '-l' 'web/sites/example.sites.php'

Command: '/home/circleci/project/vendor/bin/phpstan' 'analyse' '--configuration=vendor/wunderio/code-quality/config/phpstan.neon' '--no-ansi' '--no-interaction' '--no-progress' 'web/modules/custom'

Command: '/home/circleci/project/vendor/bin/phpunit' '--testsuite=unit'
Aborted ...

ecs
===


 [ERROR] syntax error, unexpected '|', expecting variable (T_VARIABLE)

To skip commit checks, add -n or --no-verify flag to commit command

tormi · 2021-05-26T17:43:10Z

Yeah, it's defined in vendor/wunderio/code-quality/.circleci/config.yml:

version: 2
jobs:
  # Install all dependencies and run check tasks.
  build_and_test:
    docker:
      - image: circleci/php:7.3.9-cli-node

tormi · 2021-05-26T17:44:30Z

Also in here vendor/wunderio/code-quality/tests/PhpCompatibility/PhpCompatibilityTaskTest.php:

    $taskConfig->method('getOptions')->willReturn([
      'standard' => 'php-compatibility.xm',
      'testVersion' => '7.3',
      'extensions' => ['php'],
      'run_on' => ['.'],
      'ignore_patterns' => ['/vendor/'],
      'parallel' => 10,
    ]);

tormi · 2021-05-26T18:14:07Z

Changed the PHP version to 7.3 locally and rerun ecs task, no errors:

➜  drupal-project git:(feature/lando-phpunit-php-7.4) ✗ lando grumphp run --tasks=ecs                
GrumPHP is sniffing your code!

Running tasks with priority 0!
==============================

Running task 1/1: ecs... ✔
➜  drupal-project git:(feature/lando-phpunit-php-7.4) ✗ lando php -v
PHP 7.3.27 (cli) (built: Apr 10 2021 14:33:57) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.27, Copyright (c) 1998-2018 Zend Technologies
    with Zend OPcache v7.3.27, Copyright (c) 1999-2018, by Zend Technologies
    with Xdebug v3.0.4, Copyright (c) 2002-2021, by Derick Rethans

tormi · 2021-05-26T18:16:56Z

And PHPUnit tests output locally with PHP 7.3:

➜  drupal-project git:(feature/lando-phpunit-php-7.4) ✗ lando phpunit '--testsuite=unit' 
PHPUnit 9.5.4 by Sebastian Bergmann and contributors.

Testing 
Add Class (Drupal\Tests\phpunit_example\Unit\AddClass)
 ✔ Add
 ✔ Add with data provider with data set 0
 ✔ Add with data provider with data set 1
 ✔ Add with bad data provider with data set 0
 ✔ Add with bad data provider with data set 1
 ✔ Add with bad data provider with data set 2
 ✔ Add with bad data provider with data set 3
 ✔ Add with bad data provider with data set 4
 ✔ Add with bad data provider with data set 5
 ✔ Add with bad data provider with data set 6
 ✔ Add with bad data provider with data set 7
 ✔ Add with bad data provider with data set 8
 ✔ Add with bad data provider with data set 9
 ✔ Add with bad data provider with data set 10
 ✔ Add with bad data provider with data set 11
 ✔ Add with bad data provider with data set 12
 ✔ Add with bad data provider with data set 13
 ✔ Add with bad data provider with data set 14
 ✔ Add with bad data provider with data set 15
 ✔ Add with bad data provider with data set 16
 ✔ Add with bad data provider with data set 17
 ✔ Add with bad data provider with data set 18
 ✔ Add with bad data provider with data set 19
 ✔ Add with bad data provider with data set 20
 ✔ Add with bad data provider with data set 21
 ✔ Add with bad data provider with data set 22
 ✔ Add with bad data provider with data set 23

Time: 00:00.091, Memory: 10.00 MB

OK (27 tests, 27 assertions)

tormi · 2021-05-26T18:33:10Z

Okay, unittest passes in CI and is using the correct PHP version:

circleci@e27c7346d55c:~/project$ 'vendor/bin/phpunit' '--testsuite=unit' -vvvv
PHPUnit 9.5.4 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.4.12
Configuration: /home/circleci/project/phpunit.xml

Testing
...........................                                       27 / 27 (100%)

Time: 00:00.039, Memory: 12.00 MB

OK (27 tests, 27 assertions)

tormi · 2021-05-26T18:36:52Z

And ecs task alone in CI:

circleci@e27c7346d55c:~/project$ vendor/bin/grumphp run --tasks=ecs -vvvv
Config file: /home/circleci/project/grumphp.yml
Working dir: /home/circleci/project
Project dir: /home/circleci/project
GIT working dir: /home/circleci/project
GIT repository dir: /home/circleci/project/.git
Bin dir: /home/circleci/project/vendor/bin
Composer file: /home/circleci/project/composer.json
[2021-05-26T18:35:09.923989+00:00] GrumPHP.DEBUG: Repository created (git dir: "/home/circleci/project/.git", working dir: "/home/circleci/project") [] []
[2021-05-26T18:35:09.924966+00:00] GrumPHP.INFO: run command: ls-files "/home/circleci/project"  [] []
[2021-05-26T18:35:09.929283+00:00] GrumPHP.DEBUG: last command (ls-files) duration: 4.21ms [] []
[2021-05-26T18:35:09.929394+00:00] GrumPHP.DEBUG: last command (ls-files) return code: 0 [] []
[2021-05-26T18:35:09.929465+00:00] GrumPHP.DEBUG: last command (ls-files) output: .circleci/config.yml .dockerignore .env.example .eslintignore .eslintrc.json .github/dependabot.yml .gitignore .lando.yml .lando/.env .lando/my_elasticsearch.yml .lando/php.ini .lando/phpunit.sh .lando/xdebug.sh .prettierrc.json .stylelintrc.json .vscode/extensions.json .vscode/launch.json .vscode/settings.json LICENSE README.md composer.json drush/Commands/PolicyCommands.php drush/README.md drush/drush.yml drush/sites/self.site.yml grumphp.yml load.environment.php package-lock.json package.json phpcs.xml phpunit.xml scripts/composer/ScriptHandler.php silta/nginx.Dockerfile silta/php.Dockerfile silta/shell.Dockerfile silta/silta-prod.yml silta/silta.yml web/.dockerignore web/modules/custom/phpunit_example/phpunit_example.info.yml web/modules/custom/phpunit_example/phpunit_example.module web/modules/custom/phpunit_example/src/AddClass.php web/modules/custom/phpunit_example/tests/src/Unit/AddClassTest.php web/sites/default/settings.php  [] []
GrumPHP is sniffing your code!

Running tasks with priority 0!
==============================

Running task 1/1: ecs...


Command: '/home/circleci/project/vendor/bin/ecs' 'check' 'web/modules/custom' '--config=vendor/wunderio/code-quality/config/ecs.php' '--no-progress-bar' '--ansi' '--no-interaction'
Running task 1/1: ecs... ✘


ecs
===


 [ERROR] syntax error, unexpected '|', expecting variable (T_VARIABLE)

To skip commit checks, add -n or --no-verify flag to commit command

tormi · 2021-05-26T19:11:30Z

Seems like there's something wrong with ecs setup itself in CI:

circleci@e27c7346d55c:~/project$ vendor/bin/ecs -vvv

 [ERROR] syntax error, unexpected '|', expecting variable (T_VARIABLE)

See wunderio/code-quality#58.

tormi · 2021-05-26T20:53:03Z

Successfully tried out psalm:

www-data@3c731425bb5d:/app$ vendor/bin/psalm      
Scanning files...
Analyzing files...

EE

ERROR: DocblockTypeContradiction - web/modules/custom/phpunit_example/src/AddClass.php:29:12 - Docblock-defined type float|int for $argument is always numeric (see https://psalm.dev/155)
      if (!is_numeric($argument)) {


ERROR: UndefinedClass - web/modules/custom/phpunit_example/tests/src/Unit/AddClassTest.php:36:28 - Class, interface or enum named Drupal\Tests\UnitTestCase does not exist (see https://psalm.dev/019)
class AddClassTest extends UnitTestCase {


------------------------------
2 errors found
------------------------------

Checks took 20.54 seconds and used 304.836MB of memory
Psalm was able to infer types for 100% of the codebase

guncha25 · 2021-06-06T18:52:24Z

@tormi @hkirsman Removed ECS and tested code complexity tests with phpstan default settings. Works as discussed. This is ready to merge.

guncha25

Works as expected. Ready for merge.

tormi mentioned this pull request Sep 1, 2020

Add PHPUnit testing setup for PHP 7.3. #121

Closed

hkirsman added a commit that referenced this pull request Feb 8, 2021

#122 Fix fatal error Trait 'Prophecy\PhpUnit\ProphecyTrait' not found.

a889d15

hkirsman added a commit that referenced this pull request Feb 8, 2021

#122 Fix phpunit.xml being break after anoter lando rebuild.

d61d8a9

tormi pushed a commit that referenced this pull request Mar 13, 2021

#122 Fix fatal error Trait 'Prophecy\PhpUnit\ProphecyTrait' not found.

fff1b52

tormi pushed a commit that referenced this pull request Mar 13, 2021

#122 Fix phpunit.xml being break after anoter lando rebuild.

95ba4a6

tormi force-pushed the feature/lando-phpunit-php-7.4 branch from d61d8a9 to 95ba4a6 Compare March 13, 2021 10:58

tormi added a commit that referenced this pull request Mar 13, 2021

#122: Upgrade Silta PHP to the 7.4.

797ab41

tormi added a commit that referenced this pull request Mar 13, 2021

#122: Upgrade CircleCI executor image to circleci-php7.4-node14-compo…

b9d6932

…ser2-v0.1.

tormi added a commit that referenced this pull request Mar 13, 2021

#122: Update all phpunit.xml paths & perform --migrate-configuration.

0e2698b

tormi added a commit that referenced this pull request Mar 13, 2021

#122: Move SIMPLETEST* envvars to phpunit.xml, add force="true" to SI…

fd2e63d

…MPLETEST_BASE_URL.

tormi added a commit that referenced this pull request Mar 13, 2021

#122: Update Running tests section in readme.

206457c

tormi force-pushed the feature/lando-phpunit-php-7.4 branch from 206457c to 7d6f7de Compare March 13, 2021 19:50

tormi changed the title ~~Add PHPUnit testing setup for PHP 7.4.~~ Upgrade local & Silta PHP to 7.4 & add PHPUnit testing setup. Mar 13, 2021

tormi and others added 10 commits May 20, 2021 11:02

Upgrade PHP version to 7.4.

4b522cd

Add PHPUnit testing setup for PHP 7.4.

0c30850

Update PHPUnit section at readme.

cd4ad57

#122 Fix fatal error Trait 'Prophecy\PhpUnit\ProphecyTrait' not found.

1a34960

#122 Fix phpunit.xml being break after anoter lando rebuild.

c0fb6f4

Add lando phpunit tool to the readme.

416bc6d

#122: Upgrade Silta PHP to the 7.4.

b40fb33

#122: Upgrade CircleCI executor image to circleci-php7.4-node14-compo…

2875c8c

…ser2-v0.1.

#122: Update all phpunit.xml paths & perform --migrate-configuration.

d895426

#122: Move SIMPLETEST* envvars to phpunit.xml, add force="true" to SI…

5ee7090

…MPLETEST_BASE_URL.

tormi commented May 24, 2021

View reviewed changes

grumphp.yml Outdated Show resolved Hide resolved

tormi commented May 24, 2021

View reviewed changes

122: Add phpunit_example module.

163c0a5

- Add minified phpunit_example module from https://www.drupal.org/project/examples. - Enable phpunit in grumphp.yml.

tormi added a commit that referenced this pull request May 25, 2021

#122: Update the PHPUnit section of the readme.

48ffbde

[#122] Update the PHPUnit section of the readme.

52433df

tormi force-pushed the feature/lando-phpunit-php-7.4 branch from 48ffbde to 52433df Compare May 25, 2021 13:52

tormi added 4 commits May 25, 2021 17:22

Add executor: cicd74 for CI analyze job, #122.

528fdd2

Revert "Add executor: cicd74 for CI analyze job, #122."

49c94d0

This reverts commit 528fdd2.

Add run_on parameter to grumphp phpcs task, #122.

d179435

Replace multiple possible datatypes with mixed one.

8658c52

This tries to resolve the following error in CI: [ERROR] syntax error, unexpected '|', expecting variable (T_VARIABLE)

tormi added 3 commits May 26, 2021 00:16

Revert "Replace multiple possible datatypes with mixed one."

4e8761d

This reverts commit 8658c52.

Update PHP version in config.platform, #206.

b16beb3

Add PHP version as a requirement in Composer.

c1e92b7

tormi mentioned this pull request May 26, 2021

Problems with ECS in CI environment (PHP 7.4) wunderio/code-quality#58

Open

Disable ecs tasks temporarily, #122.

0c00b06

See wunderio/code-quality#58.

Remove unsupported ECS

43ae54a

guncha25 approved these changes Jun 6, 2021

View reviewed changes

tormi merged commit 6d5a9fb into master Jun 7, 2021

tormi deleted the feature/lando-phpunit-php-7.4 branch June 7, 2021 01:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade local & Silta PHP to 7.4 & add PHPUnit testing setup. #122

Upgrade local & Silta PHP to 7.4 & add PHPUnit testing setup. #122

tormi commented Sep 1, 2020 •

edited

tormi commented Sep 1, 2020

tormi commented Sep 7, 2020 •

edited

tormi commented Sep 11, 2020

hkirsman commented Feb 8, 2021 •

edited

tormi commented Mar 13, 2021

tormi commented Mar 13, 2021

tormi commented Mar 13, 2021

tormi May 24, 2021

tormi commented May 25, 2021

tormi commented May 26, 2021

tormi commented May 26, 2021

tormi commented May 26, 2021

tormi commented May 26, 2021

tormi commented May 26, 2021 •

edited

tormi commented May 26, 2021

tormi commented May 26, 2021

tormi commented May 26, 2021

tormi commented May 26, 2021

guncha25 commented Jun 6, 2021

guncha25 left a comment

Upgrade local & Silta PHP to 7.4 & add PHPUnit testing setup. #122

Upgrade local & Silta PHP to 7.4 & add PHPUnit testing setup. #122

Conversation

tormi commented Sep 1, 2020 • edited

tormi commented Sep 1, 2020

tormi commented Sep 7, 2020 • edited

tormi commented Sep 11, 2020

hkirsman commented Feb 8, 2021 • edited

tormi commented Mar 13, 2021

tormi commented Mar 13, 2021

tormi commented Mar 13, 2021

tormi May 24, 2021

Choose a reason for hiding this comment

tormi commented May 25, 2021

tormi commented May 26, 2021

tormi commented May 26, 2021

tormi commented May 26, 2021

tormi commented May 26, 2021

tormi commented May 26, 2021 • edited

tormi commented May 26, 2021

tormi commented May 26, 2021

tormi commented May 26, 2021

tormi commented May 26, 2021

guncha25 commented Jun 6, 2021

guncha25 left a comment

Choose a reason for hiding this comment

tormi commented Sep 1, 2020 •

edited

tormi commented Sep 7, 2020 •

edited

hkirsman commented Feb 8, 2021 •

edited

tormi commented May 26, 2021 •

edited