-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade local & Silta PHP to 7.4 & add PHPUnit testing setup. #122
Merged
Merged
Changes from 17 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
4b522cd
Upgrade PHP version to 7.4.
tormi 0c30850
Add PHPUnit testing setup for PHP 7.4.
tormi cd4ad57
Update PHPUnit section at readme.
tormi 1a34960
#122 Fix fatal error Trait 'Prophecy\PhpUnit\ProphecyTrait' not found.
hkirsman c0fb6f4
#122 Fix phpunit.xml being break after anoter lando rebuild.
hkirsman 416bc6d
Add lando phpunit tool to the readme.
tormi b40fb33
#122: Upgrade Silta PHP to the 7.4.
tormi 2875c8c
#122: Upgrade CircleCI executor image to circleci-php7.4-node14-compo…
tormi d895426
#122: Update all phpunit.xml paths & perform --migrate-configuration.
tormi 5ee7090
#122: Move SIMPLETEST* envvars to phpunit.xml, add force="true" to SI…
tormi fcb6177
122: Update Running tests section in readme.
tormi 03eeec9
#122: Add better output to PHPUnit by adding --testdox parameter.
hkirsman a29d0e7
#122: Move phpunit.xml generation to separate command, commit phpunit…
hkirsman 8f4f158
#122: Run custom modules unit tests when commiting.
hkirsman 5bf1dd2
#122: Fix phpunit.grumphp.xml path in grumphp.yml.
hkirsman dacab6d
#122: Unify PHPUnit config back to 1 file.
hkirsman 877b8c2
#122: Comment out phpunit in grumphp.yml as it fails with 0 tests.
hkirsman 163c0a5
122: Add phpunit_example module.
tormi 52433df
[#122] Update the PHPUnit section of the readme.
tormi 528fdd2
Add executor: cicd74 for CI analyze job, #122.
tormi 49c94d0
Revert "Add executor: cicd74 for CI analyze job, #122."
tormi d179435
Add run_on parameter to grumphp phpcs task, #122.
tormi 8658c52
Replace multiple possible datatypes with mixed one.
tormi 4e8761d
Revert "Replace multiple possible datatypes with mixed one."
tormi b16beb3
Update PHP version in config.platform, #206.
tormi c1e92b7
Add PHP version as a requirement in Composer.
tormi 0c00b06
Disable ecs tasks temporarily, #122.
tormi 43ae54a
Remove unsupported ECS
guncha25 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
#!/bin/sh | ||
set -exu | ||
|
||
# Configure PHPUnit tests for the Lando environment. | ||
# @see: https://agile.coop/blog/drupal-phpunit-tests-lando/ | ||
# | ||
# Initially this was part of lando build process but we decided | ||
# to commit the phpunit.xml. Still the functionality of this | ||
# script could be useful as it always gets the latest distributed | ||
# configuration from core. From time to time it wouldn't hurt | ||
# try and update the file with 'lando regenerate-phpunit-config'. | ||
|
||
PHPUNIT_CONFIG=/app/phpunit.xml | ||
|
||
if [ -f "$PHPUNIT_CONFIG" ]; then | ||
rm "$PHPUNIT_CONFIG" | ||
fi | ||
|
||
cd /app | ||
cp -n web/core/phpunit.xml.dist "$PHPUNIT_CONFIG" | ||
sed -i 's|tests\/bootstrap\.php|./web/core/tests/bootstrap.php|g' "$PHPUNIT_CONFIG" | ||
sed -i 's|\.\/tests\/|./web/core/tests/|g' "$PHPUNIT_CONFIG" | ||
sed -i 's|directory>\.\/|directory>./web/core/|g' "$PHPUNIT_CONFIG" | ||
sed -i 's|directory>\.\.\/|directory>./web/core/|g' "$PHPUNIT_CONFIG" | ||
sed -i 's|<env name="SIMPLETEST_BASE_URL" value=""\/>|<env name="SIMPLETEST_BASE_URL" value="http://appserver_nginx" force="true"/>|g' "$PHPUNIT_CONFIG" | ||
sed -i 's|<env name="SIMPLETEST_DB" value=""\/>|<env name="SIMPLETEST_DB" value="sqlite://localhost/tmp/db.sqlite"/>|g' "$PHPUNIT_CONFIG" | ||
sed -i 's|<file>.\/web\/core\/tests\/TestSuites\/UnitTestSuite.php<\/file>|<directory>.\/web\/modules\/custom\/*\/tests\/src\/Unit<\/directory>|g' "$PHPUNIT_CONFIG" | ||
sed -i 's|<file>.\/web\/core\/tests\/TestSuites\/KernelTestSuite.php<\/file>|<directory>.\/web\/modules\/custom\/*\/tests\/src\/Kernel<\/directory>|g' "$PHPUNIT_CONFIG" | ||
sed -i 's|<file>.\/web\/core\/tests\/TestSuites\/FunctionalTestSuite.php<\/file>|<directory>.\/web\/modules\/custom\/*\/tests\/src\/Functional<\/directory>|g' "$PHPUNIT_CONFIG" | ||
sed -i 's|<file>.\/web\/core\/tests\/TestSuites\/FunctionalJavascriptTestSuite.php<\/file>|<directory>.\/web\/modules\/custom\/*\/tests\/src\/FunctionalJavascript<\/directory>|g' "$PHPUNIT_CONFIG" | ||
sed -i '/<file>.\/web\/core\/tests\/TestSuites\/BuildTestSuite.php<\/file>/d' "$PHPUNIT_CONFIG" | ||
vendor/bin/phpunit --migrate-configuration | ||
rm phpunit.xml.bak |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<!-- TODO set checkForUnintentionallyCoveredCode="true" once https://www.drupal.org/node/2626832 is resolved. --> | ||
<!-- PHPUnit expects functional tests to be run with either a privileged user | ||
or your current system user. See core/tests/README.md and | ||
https://www.drupal.org/node/2116263 for details. | ||
--> | ||
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" bootstrap="./web/core/tests/bootstrap.php" colors="true" beStrictAboutTestsThatDoNotTestAnything="true" beStrictAboutOutputDuringTests="true" beStrictAboutChangesToGlobalState="true" failOnWarning="true" printerClass="\Drupal\Tests\Listeners\HtmlOutputPrinter" cacheResult="false" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd"> | ||
<coverage> | ||
<include> | ||
<directory>./web/core/includes</directory> | ||
<directory>./web/core/lib</directory> | ||
<directory>./web/core/modules</directory> | ||
<directory>./web/core/modules</directory> | ||
<directory>./web/core/sites</directory> | ||
</include> | ||
<exclude> | ||
<directory>./web/core/modules/*/src/Tests</directory> | ||
<directory>./web/core/modules/*/tests</directory> | ||
<directory>./web/core/modules/*/src/Tests</directory> | ||
<directory>./web/core/modules/*/tests</directory> | ||
<directory>./web/core/modules/*/*/src/Tests</directory> | ||
<directory>./web/core/modules/*/*/tests</directory> | ||
</exclude> | ||
</coverage> | ||
<php> | ||
<!-- Set error reporting to E_ALL. --> | ||
<ini name="error_reporting" value="32767"/> | ||
<!-- Do not limit the amount of memory tests take to run. --> | ||
<ini name="memory_limit" value="-1"/> | ||
<!-- Example SIMPLETEST_BASE_URL value: http://localhost --> | ||
<env name="SIMPLETEST_BASE_URL" value="http://appserver_nginx" force="true"/> | ||
<!-- Example SIMPLETEST_DB value: mysql://username:password@localhost/databasename#table_prefix --> | ||
<env name="SIMPLETEST_DB" value="sqlite://localhost/tmp/db.sqlite"/> | ||
<!-- Example BROWSERTEST_OUTPUT_DIRECTORY value: /path/to/webroot/sites/simpletest/browser_output --> | ||
<env name="BROWSERTEST_OUTPUT_DIRECTORY" value=""/> | ||
<!-- To have browsertest output use an alternative base URL. For example if | ||
SIMPLETEST_BASE_URL is an internal DDEV URL, you can set this to the | ||
external DDev URL so you can follow the links directly. | ||
--> | ||
<env name="BROWSERTEST_OUTPUT_BASE_URL" value=""/> | ||
<!-- To disable deprecation testing completely uncomment the next line. --> | ||
<!-- <env name="SYMFONY_DEPRECATIONS_HELPER" value="disabled"/> --> | ||
<!-- Example for changing the driver class for mink tests MINK_DRIVER_CLASS value: 'Drupal\FunctionalJavascriptTests\DrupalSelenium2Driver' --> | ||
<env name="MINK_DRIVER_CLASS" value=""/> | ||
<!-- Example for changing the driver args to mink tests MINK_DRIVER_ARGS value: '["http://127.0.0.1:8510"]' --> | ||
<env name="MINK_DRIVER_ARGS" value=""/> | ||
<!-- Example for changing the driver args to webdriver tests MINK_DRIVER_ARGS_WEBDRIVER value: '["chrome", { "chromeOptions": { "w3c": false } }, "http://localhost:4444/wd/hub"]' For using the Firefox browser, replace "chrome" with "firefox" --> | ||
<env name="MINK_DRIVER_ARGS_WEBDRIVER" value=""/> | ||
</php> | ||
<testsuites> | ||
<testsuite name="unit"> | ||
<directory>./web/modules/custom/*/tests/src/Unit</directory> | ||
</testsuite> | ||
<testsuite name="kernel"> | ||
<directory>./web/modules/custom/*/tests/src/Kernel</directory> | ||
</testsuite> | ||
<testsuite name="functional"> | ||
<directory>./web/modules/custom/*/tests/src/Functional</directory> | ||
</testsuite> | ||
<testsuite name="functional-javascript"> | ||
<directory>./web/modules/custom/*/tests/src/FunctionalJavascript</directory> | ||
</testsuite> | ||
<testsuite name="build"> | ||
</testsuite> | ||
</testsuites> | ||
<listeners> | ||
<listener class="\Drupal\Tests\Listeners\DrupalListener"> | ||
</listener> | ||
</listeners> | ||
<!-- Filter for coverage reports. --> | ||
</phpunit> |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
# Dockerfile for the PHP container. | ||
FROM eu.gcr.io/silta-images/php:7.3-fpm-v0.1 | ||
FROM eu.gcr.io/silta-images/php:7.4-fpm-v0.1 | ||
|
||
COPY --chown=www-data:www-data . /app | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
# Dockerfile for the Shell container. | ||
FROM eu.gcr.io/silta-images/shell:php7.3-v0.1 | ||
FROM eu.gcr.io/silta-images/shell:php7.4-v0.1 | ||
|
||
COPY --chown=www-data:www-data . /app |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"phpspec/prophecy-phpunit"
comes from https://www.drupal.org/node/3176567.