Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Advanced parameters:" label in search interface should not be a hyperlink #695

Closed
yannickwurm opened this issue Oct 24, 2023 · 1 comment
Labels

Comments

@yannickwurm
Copy link
Member

Only the (?) that appears once the blast algorithm is unambiguous (i.e. after db selection and query entry) should be a hyperlink.

The label should be plain text

@yannickwurm
Copy link
Member Author

Screenshot 2023-11-13 at 14 29 49

yannickwurm added a commit that referenced this issue Nov 23, 2023
tadast added a commit to tadast/sequenceserver that referenced this issue Feb 20, 2024
This reverts commit ecfaa3c.

The change had an unintended consequence of disabling the help
modal for advanced features.

I'd argue that wurmlab#695
is a bit misleading - it is expected for HTML
labels to be clickable. Clicking on an input field label should
focus the input field, which it was doing. I don't think this should
change.

It just happens that the help modal trigger is crammed into the label
too, so it can perhaps get confusing when the two elements next to each other are clickable and react to the same hover - perhaps the latter needs
to change instead?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant