Handling large BLAST results #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just ran npm install and it complained the lockfile format is old and updated it.
tadast
force-pushed
the
tt/large-results
branch
from
6957a9f
to
65f04e8
Compare
Browsers might struggle to render large result sets. There's no reliable way to know, so pick an arbitrary size and warn the user, giving them a choice of downloading tabular data for local analysis or attempting to render the large result.
Invoking a method that has side-effects (calculating and assigning values, generating files etc) as a part of the initializer makes the objects much harder to test and work with. When working with reports, make result generation explicit, rather than directly invoking it as soon as the object is initialized.
tadast
force-pushed
the
tt/large-results
branch
from
65f04e8
to
e98a644
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when the queries are large and the database set is big, the search results can take up hundreds of megs or even gigabytes. Sequenceserver has an elegant way to gradually render and visualise large result sets, but it is browser and user machine-dependent whether the browser will be able to hold that many DOM elements on the page without struggling. Add a gentle user warning notifying them about the risk and allowing them to download raw result files and allowing the user to opt-in to a large result render in the browser.
Also: