Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log when makeblastdb is provided a dir without fastas #690

Merged
merged 1 commit into from Oct 10, 2023

Conversation

tadast
Copy link
Collaborator

@tadast tadast commented Oct 9, 2023

Previously, given a directory without any databases, the message would read 'All FASTAs are formatted', which could be misleading.

Tell the user explicitly when SequenceServer cannot find any FASTAs. This is helpful for the user to know so that they can double-check the path provided, or check for non-standard file extensions in the dir.

@ghost
Copy link

ghost commented Oct 9, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Previously the message would read 'All FASTAs are formatted', which
could be misleading. Tell the user explicitly when SequenceServer
cannot find any fastas. This is helpful for the user to know so
that they can double-check the path provided, or check for
non-standard file extensions in the dir.
@yannickwurm yannickwurm merged commit c815519 into wurmlab:master Oct 10, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants