Show blast errors when possible #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you enter a malformed query, it fails with a generic error message. Bubble up BLAST's stderr to be shown in the error modal when possible.
When an issue with a user query or configuration occurs, we were just raising an exception and the sinatra's error block was returning 500 error page. When we know the shape of the error and build a JSON response for it, it's more likely to be a 4** type of error, so default to 422 for a status in such cases. This is not ideal, but an improvement when it comes to HTTP status semantics and also helps manage errors when Sequenceserver is deployed to a server i.e. passenger can be configured to intercept 500 pages yet 4** ones would still be handled by the app and display useful error messages to the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you enter a malformed query, it fails with a generic error message. Bubble up BLAST's stderr to be shown in the error modal when possible.
This is what it looks like after the change:
I think this half-way solves #691