Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the job 404 exception error #666 #710

Merged
merged 8 commits into from Dec 21, 2023
Merged

Conversation

gorsyan
Copy link
Contributor

@gorsyan gorsyan commented Dec 7, 2023

In job.rb file return nil if the job doesn't exist.
In routes.rb file where the Job.fetch(id) method is called, handle the scenario when Job.fetch returns nil and add corresponding halt 404.

422 exception handling
@gorsyan gorsyan changed the title Master Work in progress for issue #666 Dec 7, 2023
Reverts to previous version of .gitignore
@ghost
Copy link

ghost commented Dec 7, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@gorsyan gorsyan marked this pull request as ready for review December 21, 2023 17:30
@gorsyan gorsyan changed the title Work in progress for issue #666 Fixed the job 404 exception error #666 Dec 21, 2023
@yannickwurm yannickwurm merged commit 22aa5e9 into wurmlab:master Dec 21, 2023
4 of 7 checks passed
@yannickwurm
Copy link
Member

Thank you @gorsyan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants